Last modified: 2013-04-02 23:15:12 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T47993, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 45993 - Revert domino hacks once 1.0.9 is released upstream.
Revert domino hacks once 1.0.9 is released upstream.
Status: RESOLVED FIXED
Product: Parsoid
Classification: Unclassified
DOM (Other open bugs)
unspecified
All All
: Normal normal
: ---
Assigned To: C. Scott Ananian
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2013-03-11 19:07 UTC by C. Scott Ananian
Modified: 2013-04-02 23:15 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description C. Scott Ananian 2013-03-11 19:07:54 UTC 
We have a number of evil hacks to domino in lib/domino.js which monkey-patch the sources to incorporate some bug fixes merged upstream but not yet released.

Once the next version of domino is released (1.0.9), our package.json should be updated to require this version of domino, and our hacks in lib/domino.js should be removed.
Comment 1 C. Scott Ananian 2013-03-11 19:09:06 UTC 
"We want a new domino release" is filed upstream as https://github.com/fgnass/domino/issues/19
Comment 2 C. Scott Ananian 2013-03-11 19:11:10 UTC 
Oh, and the monkey-patching we're doing seems to break with node 0.10 -- I think the latest Node is more careful about enforcing write-only properties, so we'd have to do much evil-er stuff to monkey-patch... I'd prefer just to get a new upstream domino.
Comment 3 C. Scott Ananian 2013-04-02 20:13:47 UTC 
Upstream release occurred.  Patch to review domino hacks is: https://gerrit.wikimedia.org/r/57176
Comment 4 ssastry 2013-04-02 23:15:12 UTC 
And merged.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links