Last modified: 2014-06-09 06:18:00 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T48040, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 46040 - Prompt the user to confirm a page change while an LQT edit form is open
Prompt the user to confirm a page change while an LQT edit form is open
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
LiquidThreads (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Alex Monk
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-03-12 20:15 UTC by Krinkle
Modified: 2014-06-09 06:18 UTC (History)
7 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Krinkle 2013-03-12 20:15:43 UTC
.. and I can't press Back in the browser to get it back because LQT edit area is dynamically created with javascript.

Just lost another page, very annoying.
Comment 1 Nemo 2013-03-12 20:26:01 UTC
Isn't this rather a bug with the thing that creates a dialog "do you want to leave this page?"? (I don't know what component that is, I think it was introduced with Vector?)
Comment 2 Siebrand Mazeland 2013-04-15 11:17:05 UTC
Moving component to LiquidThreads. There are several issues like this in Lqt, see for example bug 46336 (I'm almost certain there's a much older report of the same issue).
Comment 3 Bartosz Dziewoński 2013-04-15 13:23:15 UTC
(In reply to comment #1)
> Isn't this rather a bug with the thing that creates a dialog "do you want to
> leave this page?"? (I don't know what component that is, I think it was
> introduced with Vector?)

This was part of the Vector extension, and is part of core now (merged per bug 46514). It could likely be expanded to be able to cover additional fields.
Comment 4 Gerrit Notification Bot 2013-04-15 16:35:13 UTC
Related URL: https://gerrit.wikimedia.org/r/59159 (Gerrit Change I6234a7651f70034f8a17ad242ddcf5793f0b899d)
Comment 5 Gerrit Notification Bot 2013-08-17 09:54:49 UTC
Change 59159 merged by jenkins-bot:
Prompt the user to confirm a page change while an LQT edit form is open

https://gerrit.wikimedia.org/r/59159
Comment 6 Nemo 2013-08-17 10:32:04 UTC
Approved by Nikerabbit.
Comment 7 Nemo 2013-08-25 07:53:32 UTC
Reopening: there is something wrong. The warning is displayed every time you leave a LQT-enabled page, even if you have just opened it and not touched anything.
Comment 8 Gerrit Notification Bot 2013-08-25 13:25:04 UTC
Change 80803 had a related patch set uploaded by Alex Monk:
Fix for I6234a765

https://gerrit.wikimedia.org/r/80803
Comment 9 Gerrit Notification Bot 2013-08-25 20:32:30 UTC
Change 80803 merged by jenkins-bot:
Fix for I6234a765

https://gerrit.wikimedia.org/r/80803
Comment 10 Yuki Shira 2013-08-26 21:28:18 UTC
The same alert appears when editing a summary for a LQT-enabled page.
Could you reopen this bug?
Comment 11 Nemo 2013-08-27 13:35:02 UTC
Confirmed. :( I had tested editing the summary first but then forgot to retest. (You can edit status too now, btw.)
Comment 12 Gerrit Notification Bot 2013-09-02 15:16:44 UTC
Change 82251 had a related patch set uploaded by Alex Monk:
Don't show edit form open warning when saving thread summary

https://gerrit.wikimedia.org/r/82251
Comment 13 Gerrit Notification Bot 2013-09-03 13:27:35 UTC
Change 82251 merged by jenkins-bot:
Don't show edit form open warning when saving thread summary

https://gerrit.wikimedia.org/r/82251
Comment 14 James Forrester 2013-09-03 15:16:46 UTC
Think this is now fixed, given Krenair's latest patch (thank you again!). Closing, provisionally.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links