Last modified: 2013-03-17 19:44:21 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T48046, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 46046 - Mention notifications targeting non existing users should not be fired
Mention notifications targeting non existing users should not be fired
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
Echo (Other open bugs)
unspecified
All All
: Unprioritized normal (vote)
: ---
Assigned To: bsitu
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2013-03-12 21:56 UTC by Dario Taraborelli
Modified: 2013-03-17 19:44 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Dario Taraborelli 2013-03-12 21:56:00 UTC 
Currently they are stored with a recipient user_id set to 0, see for example User:Okeyes in http://www.mediawiki.org/w/index.php?title=User_talk:LWelling&diff=prev&oldid=656919
Comment 1 Sam Reed (reedy) 2013-03-12 22:06:33 UTC 
Looks like the code only saves the user_id, so pretty much any action where it's 0, it should be ignored/skipped/whatever, as there's no way to differentiate between anon/non existent users...


In the maintenance script:
				$userId = intval( $row->eeb_user_id );
				if ( $userId && $userId > $startUserId ) {
					$emailBatch = MWEchoEmailBatch::newFromUserId( $userId );
Comment 3 Alex Monk 2013-03-17 19:44:21 UTC 
Merged by Kaldari on the 15th.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links