Last modified: 2013-04-22 16:14:45 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T48052, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 46052 - Refactor the storage methods [was: $wgOpenIDConsumerStorePath should use wfTempDir() ]
Refactor the storage methods [was: $wgOpenIDConsumerStorePath should use wfTe...
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
OpenID (Other open bugs)
master
All All
: High trivial (vote)
: ---
Assigned To: T. Gries
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2013-03-13 01:57 UTC by Sam Reed (reedy)
Modified: 2013-04-22 16:14 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Sam Reed (reedy) 2013-03-13 01:57:40 UTC 
$wgOpenIDConsumerStorePath by default uses /tmp, which isn't going to work on windows etc.

wfTempDir() should be used
Comment 1 T. Gries 2013-03-13 07:23:12 UTC 
like $wgExtensionAssetsPath it ( wfTempDir() or $wgTmpDirectory ) cannot be simply used in OpenID.php because setup.php did not run then, and the value is not yet setup when it is needed in the current program structure.

I will code a similar change like already done in 
https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/extensions/OpenID.git;a=commit;h=8c56257d6f7e4f28d1a9b49988f4cafaea15de1b .
Comment 2 T. Gries 2013-03-16 07:26:02 UTC 
see  https://gerrit.wikimedia.org/r/54117
Comment 3 T. Gries 2013-03-16 07:50:21 UTC 
fixed in https://gerrit.wikimedia.org/r/#/c/54117/4
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links