Last modified: 2013-03-18 15:44:29 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T48285, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 46285 - unit tests fails cause of a private property
unit tests fails cause of a private property
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
ActiveAbstract (Other open bugs)
master
All All
: Unprioritized normal (vote)
: ---
Assigned To: Antoine "hashar" Musso (WMF)
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2013-03-18 15:20 UTC by Antoine "hashar" Musso (WMF)
Modified: 2013-03-18 15:44 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Antoine "hashar" Musso (WMF) 2013-03-18 15:20:49 UTC 
The unit tests for ActiveAbstract fails with MediaWiki core master:

 1) BackupDumperAbstractsTest::testXmlDumpsBackupUseCase
 Undefined property: BackupDumperAbstractsTest::$useTemporaryTables

Since the property is private in core we need an accessor:
 https://gerrit.wikimedia.org/r/#/c/54468/

And let the extension uses it:
 https://gerrit.wikimedia.org/r/#/c/54374/
Comment 1 Antoine "hashar" Musso (WMF) 2013-03-18 15:21:48 UTC 
A nice bug report to assemble both Gerrit patches \O/
Comment 2 Antoine "hashar" Musso (WMF) 2013-03-18 15:44:29 UTC 
Resolved thanks to Brion quick review!
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links