Last modified: 2013-05-21 08:46:08 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T48286, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 46286 - Jenkins: phpcs should skip i18n.php files
Jenkins: phpcs should skip i18n.php files
Status: RESOLVED FIXED
Product: Wikimedia
Classification: Unclassified
Continuous integration (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Krinkle
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2013-03-18 15:50 UTC by Antoine "hashar" Musso (WMF)
Modified: 2013-05-21 08:46 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Antoine "hashar" Musso (WMF) 2013-03-18 15:50:04 UTC 
i18n.php files are simply toooo big to be parsed with phpcs. We should just skip them in both -phpcs and -phpcs-HEAD jobs.
Comment 1 Antoine "hashar" Musso (WMF) 2013-04-11 08:40:52 UTC 
Timo changed phpcs to ignore *.i18n.php with  https://gerrit.wikimedia.org/r/#/c/58638/

That probably solve the issue.
Comment 2 Krinkle 2013-04-11 08:49:29 UTC 
Where else do we have i18n files?

I added an ignore for it because I noticed locally that it took a significant amount of time running through the over 100,000 tokens in Installer.i18n.php.

I guess however that it also fixed it for extensions, I didn't realise it at the time since there was a mention of "languages/Messages" which led me to believe this was core specific.
Comment 3 Krinkle 2013-04-11 08:57:08 UTC 
Leaving open until all mwext jobs are updated. I only generated the configuration for core and synced it.
Comment 4 Antoine "hashar" Musso (WMF) 2013-05-21 08:46:08 UTC 
For phpcs-HEAD : https://gerrit.wikimedia.org/r/#/c/63571/

All mwext-*-phpcs-HEAD have been updated already. So I guess this is solved now.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links