Last modified: 2013-03-19 13:38:12 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T48323, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 46323 - UIFeedback: Patch for update.php broken (ALTER TABLE syntax error)
UIFeedback: Patch for update.php broken (ALTER TABLE syntax error)
Status: RESOLVED WORKSFORME
Product: MediaWiki extensions
Classification: Unclassified
Other (Other open bugs)
master
All All
: Normal normal (vote)
: ---
Assigned To: LB
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-03-19 13:36 UTC by Krinkle
Modified: 2013-03-19 13:38 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Krinkle 2013-03-19 13:36:26 UTC
ALTER TABLE patches should not include /*$wgDBTableOptions*/, that's only when creating new tables.

The resulting syntax is invalid in MySQL.



Creating uifeedback table ...A database query syntax error has occurred.
The last attempted database query was:
"ALTER TABLE `uifeedback_reviews`
 ADD CONSTRAINT FOREIGN KEY
 (uifr_feedback_id) REFERENCES uifeedback (uif_id)
 ENGINE=InnoDB, DEFAULT CHARSET=binary
"
from within function "DatabaseBase::sourceFile( /srv/mediawiki/extensions/UIFeedback/table.sql )".
Database returned error "1064: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'ENGINE=InnoDB, DEFAULT CHARSET=binary' at line 4 (localhost)"
Comment 1 Krinkle 2013-03-19 13:38:12 UTC
Wasn't committed yet.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links