Last modified: 2014-04-12 13:46:59 UTC
Created attachment 11956 [details] screenshot of experimental Agora applied to edit page Extension:Agora has the experimental feature to apply mw-ui-button styles to buttons on existing pages using JavaScript. (Normally you would explicitly add these styles to elements of particular pages.) If I enable this on page edit on my local wiki: * The buttons have no spacing, I think this is by design. * The line height remains 1.5em so the buttons push below the "Cancel | Editing help (opens in new window) links" * The first button has has rounded corners, the middle is squared, but the last doesn't have rounded right corners. The CSS selectors input.mw-ui-button[type="submit"]:first-child and input.mw-ui-button[type="submit"] do this, but the one to round the last-child doesn't select the last button. Did we intend these rules to only apply inside a mw-ui-button-group ?
Munaf, Pau, for your consideration...
Side note: Would the Agora maintainers like to have a dedicated component in this Bugzilla? If so, please tell me who to set as default assignee (nobody@ ?) and default CC.
Created attachment 15088 [details] As of 2014. A year later, the mediawiki.ui buttons we have in core look nothing like the screenshot here and don't really have these issues (the default look [1] – screenshot attached – looks sane to me). [1] Obtained by running $('.editButtons input').addClass('mw-ui-button') .first().addClass('mw-ui-constructive')
