Last modified: 2013-09-18 15:21:54 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T48366, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 46366 - Use formatter for claim diffs
Use formatter for claim diffs
Status: VERIFIED FIXED
Product: MediaWiki extensions
Classification: Unclassified
WikidataRepo (Other open bugs)
master
All All
: Unprioritized normal (vote)
: ---
Assigned To: Wikidata bugs
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2013-03-20 14:44 UTC by Aude
Modified: 2013-09-18 15:21 UTC (History)
8 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Aude 2013-03-20 14:44:15 UTC 
Now that we have an item formatter class, there are uses for it in various places in the code.

Claim diffs is one specific place that needs it and get rid of duplicate code there.
Comment 1 Gerrit Notification Bot 2013-08-16 14:02:06 UTC 
Change 79332 had a related patch set uploaded by Tobias Gritschacher:
Register StringFormatter

https://gerrit.wikimedia.org/r/79332
Comment 2 Gerrit Notification Bot 2013-08-16 14:14:39 UTC 
Change 79332 merged by jenkins-bot:
Register StringFormatter

https://gerrit.wikimedia.org/r/79332
Comment 3 tobias.gritschacher 2013-08-19 08:59:04 UTC 
still a lot work to be done here..
Comment 4 Jeroen De Dauw 2013-08-21 14:47:29 UTC 
This bug appears to be about ClaimDifferenceVisualizer::getSnakValue
Comment 5 Gerrit Notification Bot 2013-09-06 14:00:20 UTC 
Change 83091 had a related patch set uploaded by Daniel Kinzler:
(bug 46366) Use SnakFormatter for diffs and summaries

https://gerrit.wikimedia.org/r/83091
Comment 6 Gerrit Notification Bot 2013-09-16 14:01:23 UTC 
Change 83091 merged by jenkins-bot:
(bug 46366) Use SnakFormatter for diffs and summaries

https://gerrit.wikimedia.org/r/83091
Comment 7 Gerrit Notification Bot 2013-09-17 01:36:51 UTC 
Change 84477 had a related patch set uploaded by Aude:
I am not sure if/why this patch is a problem for travis, but let's see if this makes travis happy

https://gerrit.wikimedia.org/r/84477
Comment 8 Gerrit Notification Bot 2013-09-17 02:01:21 UTC 
Change 84477 merged by jenkins-bot:
Revert "(bug 46366) Use SnakFormatter for diffs and summaries"

https://gerrit.wikimedia.org/r/84477
Comment 9 Gerrit Notification Bot 2013-09-17 02:12:38 UTC 
Change 84478 had a related patch set uploaded by Aude:
Revert "Revert "(bug 46366) Use SnakFormatter for diffs and summaries""

https://gerrit.wikimedia.org/r/84478
Comment 10 Gerrit Notification Bot 2013-09-17 08:08:12 UTC 
Change 84492 had a related patch set (by Tobias Gritschacher) published:
(bug 46366) Use SnakFormatter for summaries

https://gerrit.wikimedia.org/r/84492
Comment 11 Gerrit Notification Bot 2013-09-17 08:08:21 UTC 
Change 84496 had a related patch set uploaded by Tobias Gritschacher:
(bug 46366) Use SnakFormatter for diffs

https://gerrit.wikimedia.org/r/84496
Comment 12 Gerrit Notification Bot 2013-09-17 08:38:58 UTC 
Change 84496 merged by Tobias Gritschacher:
(bug 46366) Use SnakFormatter for diffs

https://gerrit.wikimedia.org/r/84496
Comment 13 Gerrit Notification Bot 2013-09-17 08:46:59 UTC 
Change 84492 merged by Tobias Gritschacher:
(bug 46366) Use SnakFormatter for summaries

https://gerrit.wikimedia.org/r/84492
Comment 14 Gerrit Notification Bot 2013-09-17 08:48:12 UTC 
Change 84478 abandoned by Aude:
Revert "Revert "(bug 46366) Use SnakFormatter for diffs and summaries""

https://gerrit.wikimedia.org/r/84478
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links