Last modified: 2014-06-09 06:18:03 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T48388, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 46388 - "new messages" count not updating when marking some messages as read
"new messages" count not updating when marking some messages as read
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
LiquidThreads (Other open bugs)
master
All All
: Low minor (vote)
: ---
Assigned To: Alex Monk
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-03-20 20:56 UTC by Jesús Martínez Novo (Ciencia Al Poder)
Modified: 2014-06-09 06:18 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Jesús Martínez Novo (Ciencia Al Poder) 2013-03-20 20:56:57 UTC
On mediawiki.org I have several threads watched of some discussions in Project:Support_desk. When marking some of them as read, the number of "new message" in personal tools is not decreasing, even if I open another page or several pages on the same wiki. But when I load Special:NewMessages again (by clicking on the New Messages link) then the number is refreshed, displaying the real number of messages, and if I navigate to other pages on the wiki, the number stays correct as it should be.

I can reproduce it consistently.

But it seems it doesn't happen with some other discussions.

For example, I have 2 different threads with 1 new message on each from Project:Support_desk, and 1 thread with 1 new message from another page:
- New messages count = 3
- Marking as read one from Project:Support_desk, New messages count stay
  at 3 (wrong!)
- Marking as read one from another page, New messages count decreases to 2
- I navigate to other pages on the wiki, New messages count stay at 2.
- I go to Special:NewMessages again, and New messages count goes to 1 (correct!).
- I navigate to other pages on the wiki, New messages count stay at 1.

Maybe the count isn't decreased when there are still new messages from other threads of the same page?

I'll wait until I got some more testing and will update the bug accordingly.
Comment 1 Andre Klapper 2013-03-21 09:24:18 UTC
This should have gotten fixed ~four weeks ago in bug 24292 by Krenair.
CC'ing Krenair.
Comment 2 Jesús Martínez Novo (Ciencia Al Poder) 2013-03-28 19:40:28 UTC
Ok, I think I've found the pattern now.

Whenever I mark a message as read, the number of pending messages is set to the real number of messages plus one. It doesn't matter if they're threads of the same page or not. And it seems like a caching issue on the server, not the client.

For example, having 4 new messages, marking one as read, the api call returns 4 messages pending. Marking another one as read returns 3, and so on. The thing is that the counter is cached in the server somewhere because navigating to other pages maintains the counter at one above the real number. Accessing Special:NewMessages again refreshes the counter to the real number.

Maybe after marking as read, the message count is read from a slave server that hasn't been updated already, and then that (wrong) result is cached again?
Comment 3 Alex Monk 2013-04-07 17:16:14 UTC
It is indeed being read from a slave server... Which would explain why this didn't show up in testing.
Comment 4 Gerrit Notification Bot 2013-04-07 17:22:46 UTC
Related URL: https://gerrit.wikimedia.org/r/57930 (Gerrit Change I3b3dc98bd1dc6cba44a1c8dfdeba745c523a2086)
Comment 5 Jesús Martínez Novo (Ciencia Al Poder) 2013-05-20 08:20:56 UTC
Gerrit change #57930 merged, and now it works. Thanks!

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links