Last modified: 2013-04-22 16:15:24 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T48392, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 46392 - Add a contact us link into the english wikipedia footer
Add a contact us link into the english wikipedia footer
Status: RESOLVED FIXED
Product: Wikimedia
Classification: Unclassified
Site requests (Other open bugs)
wmf-deployment
All All
: Normal enhancement (vote)
: ---
Assigned To: Ryan Kaldari
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-03-20 23:14 UTC by Derk-Jan Hartman
Modified: 2013-04-22 16:15 UTC (History)
10 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Derk-Jan Hartman 2013-03-20 23:14:14 UTC
The request is to add the following to the configuration for the english wikipedia


$wgHooks['SkinTemplateOutputPageBeforeExec'][] = 'enwikiContact';
function enwikiContact( $sk, &$tpl ) {
        $tpl->set( 'contact', $sk->footerLink( 'contact', 'contact-url' ) );
        $tpl->data['footerlinks']['places'][] = 'contact';
        return true;
}

This would enable us to remove the 'hack' of adding it trough MediaWiki:Wikimedia-copyright that was used the last couple of years.
Comment 1 MZMcBride 2013-04-02 21:10:38 UTC
I've just requested that this li HTML element use an HTML id attribute here: <https://en.wikipedia.org/w/index.php?title=MediaWiki_talk:Wikimedia-copyright&oldid=548382142#Minor_code_tweaks>.

If this gets re-implemented in server-side logic, it would be nice if the li element specified an HTML id (as all the other li elements in the footer do). I can't tell from the PHP snippet in comment 0 whether the HTML output would include such an HTML id.
Comment 2 Daniel Friesen 2013-04-02 21:42:51 UTC
Footericons <li> id's are skin dependent. In fact if it's even a li at all is dependent on the skin.

Vector will use #footer-places-contact and MonoBook will use #contact. (Which actually sounds like a problem in itself)
Comment 3 Derk-Jan Hartman 2013-04-03 12:26:51 UTC
@Daniel: The fact that it works like that right now is actually just to preserve backwards compatibility in monobook. I guess we could just special case the 3 old link ids in mono book, so that the other (additional links) can all use the prefix no matter which skin they use.
Comment 4 Ryan Kaldari 2013-04-04 20:46:26 UTC
Added to CommonSettings.php:
https://gerrit.wikimedia.org/r/#/c/57649/
Awaiting review.
Comment 5 Gerrit Notification Bot 2013-04-16 17:33:31 UTC
Related URL: https://gerrit.wikimedia.org/r/59430 (Gerrit Change Ic742664871bbf75778914cc2b823d8b7e0920698)

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links