Last modified: 2013-05-29 08:02:30 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T48467, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 46467 - Change merged without Verified
Change merged without Verified
Status: RESOLVED WORKSFORME
Product: Wikimedia
Classification: Unclassified
Git/Gerrit (Other open bugs)
wmf-deployment
All All
: High major (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2013-03-22 22:20 UTC by Chad H.
Modified: 2013-05-29 08:02 UTC (History)
7 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Chad H. 2013-03-22 22:20:27 UTC 
https://gerrit.wikimedia.org/r/#/c/55289/ was merged without a Verified scored. Unlike bug 43485, which is a race condition in which the score just doesn't show (but exists), this bug is about there actually not being a V+2 at all. This is bad.
Comment 1 christian 2013-04-14 23:45:09 UTC 
After the change's third comment the change briefly had both
Verified+2, and Code-Review+2.

But given that the "Change has been successfully merged into the git
repository." comment is not from "jenkins-bot" but a user, can it be
the user submitted directly?
Comment 2 Antoine "hashar" Musso (WMF) 2013-05-29 08:02:30 UTC 
Seems to have been submitted by the user using CR+2 as well. When Zuul receives the CR+2 event, it removes the Verified flag and starts the gate-and-submit pipeline.  Since the change got merged, Zuul only reports the message since it is not possible to cast a vote on a closed change.

So that is more or less working as expected :-)
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links