Last modified: 2013-04-12 18:45:47 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T48501, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 46501 - Rebase in gerrit before merge to git
Rebase in gerrit before merge to git
Status: RESOLVED WONTFIX
Product: Wikimedia
Classification: Unclassified
Git/Gerrit (Other open bugs)
wmf-deployment
All All
: Normal enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-03-24 01:29 UTC by db [inactive,noenotif]
Modified: 2013-04-12 18:45 UTC (History)
7 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description db [inactive,noenotif] 2013-03-24 01:29:02 UTC
To keep the history in git linear and avoids merges it is necessary to rebase before (fast-forward) merge a commit into git. This is not happen all the time by all reviewers.

So please disable Code-Review+2 for non current patch sets or let jenkins rebase before merge, when needed. The last one makes it necessary, that a rebase by jenkins keeps all Code-Review+1 and Code-Review+2, so jenkins can merge it after the tests passed.

Thanks.
Comment 1 Andre Klapper 2013-03-25 08:47:48 UTC
Tentatively moving to Git/Gerrit, might need to be under Testing Infrastructure for Jenkins though.
Comment 2 Chad H. 2013-03-25 12:00:49 UTC
We could change the merge strategy to fast-forward only, which would mean there's an implicit rebase by Gerrit before merging (as long as it can).
Comment 3 Platonides 2013-03-25 13:21:11 UTC
This is not always desired. The problem would be separating those cases where the parent commit doesn't matter (it's just noise) from those where it does.
Comment 4 Chad H. 2013-04-12 18:45:47 UTC
Marking this as WONTFIX.

* For MediaWiki core (and any other high-traffic repositories), doing this creates pointless rebases and wastes developer time. We tried it with the puppet repo, and quickly changed it back.

* For any other repo that doesn't change frequently or only has a few authors, the project owner can change the merge strategy themselves.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links