Last modified: 2014-09-04 02:58:34 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T48510, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 46510 - The methods of a string should default to mw.ustring, not string
The methods of a string should default to mw.ustring, not string
Status: RESOLVED WONTFIX
Product: MediaWiki extensions
Classification: Unclassified
Scribunto (Other open bugs)
unspecified
All All
: Unprioritized trivial with 1 vote (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2013-03-24 15:48 UTC by CodeCat
Modified: 2014-09-04 02:58 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description CodeCat 2013-03-24 15:48:09 UTC 
When someone writes text:sub(4, 8) it uses string.sub(text, 4, 8). Wikis widely use Unicode, so it's not a good idea. It should really use mw.ustring.sub(text, 4, 8) instead. While this will add a bit of overhead, it is a much safer default and less likely to break characters in half.
Comment 1 MZMcBride 2013-03-24 16:08:02 UTC 
I think there were portability concerns with doing something like this.
Comment 2 Brad Jorsch 2013-03-24 21:59:57 UTC 
Considering Gerrit change #48781 undid something like this, I think it's fairly safe to close this as WONTFIX.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links