Last modified: 2014-03-29 21:15:52 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T48588, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 46588 - worker-javascript.js is 404 when editing
worker-javascript.js is 404 when editing
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
JavaScript (Other open bugs)
1.22.0
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-03-26 23:05 UTC by Mark A. Hershberger
Modified: 2014-03-29 21:15 UTC (History)
7 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Mark A. Hershberger 2013-03-26 23:05:12 UTC
https://www.mediawiki.org/w/index.php?title=MediaWiki:Gadget-collapsibleTables.js&action=edit results in the following js error:

"NetworkError: 404 Not Found - https://www.mediawiki.org/w/worker-javascript.js"

worker...ript.js
WorkerErrorEvent { message="Script file not found: worker-javascript.js", lineno=0, type="error", more...}
mode-c...8777074 (line 1)

uncaught exception: [object WorkerErrorEvent]

Script file not found: worker-javascript.js
Comment 1 Krinkle 2013-03-26 23:06:29 UTC
What gadgets, user scripts or browser scripts do you have that load a file called worker-javascript.js?

That file isn't anywhere in any Wikimedia maintained codebase that I know of.
Comment 2 Mark A. Hershberger 2013-03-26 23:25:00 UTC
Looks like it is related to https://github.com/ajaxorg/ace/issues/655 and the ACE editor which is loaded from https://toolserver.org/~brion/extensions/CodeEditor/ which comes from the "Code editor" gadget.
Comment 3 Ori Livneh 2013-03-27 03:34:20 UTC
(In reply to comment #2)
> Looks like it is related to https://github.com/ajaxorg/ace/issues/655 and the
> ACE editor which is loaded from
> https://toolserver.org/~brion/extensions/CodeEditor/ which comes from the
> "Code
> editor" gadget.

I ran into this issue with the JSON background linter, which the Ace editor kept trying to load in the background when I enabled it on the Schema namespace on metawiki. CodeEditor uses a CommonJS-like require() that has been superficially hacked to work with ResourceLoader.

I thought I fixed it in Gerrit change Ia60ef2122, so I'm not sure why you're running into it. I'll poke around a bit.
Comment 4 Andre Klapper 2013-04-23 10:28:55 UTC
(In reply to comment #3 by Ori)
> I'll poke around a bit.

Ori: Did you have time to do that?
Comment 5 Ori Livneh 2013-04-28 18:03:21 UTC
(In reply to comment #4)
> Ori: Did you have time to do that?

Sorry for the delay in updating this bug. I did poke around and could not reproduce the bug. I'm not an admin on mediawikiwiki and so was not able to test Mark's URL (from comment #2) directly, but an admin just checked and confirmed that there is no 404 request to worker-javascript.js.
Comment 6 MZMcBride 2013-04-28 18:35:15 UTC
This is easy to reproduce with the "Code editor" gadget enabled on mediawiki.org.

It's something to do with the experimental "Code editor" gadget that Brion made a while ago. I'd recommend simply disabling the gadget. :-)

https://toolserver.org/~brion/extensions/CodeEditor/modules/ace/ <-- "worker-javascript.js" is here, it looks like.

https://www.mediawiki.org/wiki/MediaWiki:Gadget-CodeEditor.js is where to start to debug this properly. But really, let's just disable the gadget and enable the CodeEditor extension on JS/CSS pages (the subject of bug 39653).
Comment 7 Ori Livneh 2013-04-28 20:01:34 UTC
Ah. Brion simply needs to update his clone of the extension on the ToolServer so that it includes the patch that disables background linting for JS pages (8ee19004b3).
Comment 8 Derk-Jan Hartman 2014-03-29 21:15:41 UTC
This is now superseded by the CodeEditor extension, and fixed with:
https://gerrit.wikimedia.org/r/#/c/118979/
https://gerrit.wikimedia.org/r/#/c/118980/

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links