Last modified: 2013-07-29 22:19:51 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T48636, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 46636 - comment replies aren't nested
comment replies aren't nested
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
CodeReview (Other open bugs)
master
All All
: Low normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2013-03-28 13:48 UTC by Randy
Modified: 2013-07-29 22:19 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Randy 2013-03-28 13:48:47 UTC 
Using a recent snapshot of master (4a7710d) with MW 1.19.

When a code review comment is replied to, it is not properly nested under the parent.  Instead, it just appears at the end of the list as a new top-level comment.   There is effectively no "threading" of review comments.
Comment 1 Andre Klapper 2013-04-02 09:34:03 UTC 
[Note: CodeReview is not under active development anymore. In case you're interested in taking over maintainership, please drop a line here.]
Comment 2 Jack Phoenix 2013-07-29 22:19:51 UTC 
(In reply to comment #0)
> Using a recent snapshot of master (4a7710d) with MW 1.19.
> 
> When a code review comment is replied to, it is not properly nested under the
> parent.  Instead, it just appears at the end of the list as a new top-level
> comment.   There is effectively no "threading" of review comments.
Fixed in Gerrit change #76282, which was just merged to master.

(In reply to comment #1)
> [Note: CodeReview is not under active development anymore. In case you're
> interested in taking over maintainership, please drop a line here.]
Consider me interested in that, then! :-)
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links