Last modified: 2014-04-10 02:43:14 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T48661, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 46661 - loadRequest() is called twice
loadRequest() is called twice
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
MultiUpload (Other open bugs)
master
All All
: Normal normal (vote)
: ---
Assigned To: Lee Worden
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2013-03-28 22:01 UTC by Lee Worden
Modified: 2014-04-10 02:43 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Lee Worden 2013-03-28 22:01:38 UTC 
The MultipleUpload class provides its own version of SpecialUpload's loadRequest() function, and calls it from MultipleUpload::__construct().  But SpecialUpload also calls loadRequest() from its execute() function, so when the MultipleUpload page runs, the function gets called twice.  It looks like it does redundant work, including allocating a bunch of UploadBase objects twice, and it might have other unintended effects.
Comment 1 Lee Worden 2014-04-10 02:42:53 UTC 
Checked in a new version of MultiUpload, no longer have this issue
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links