Last modified: 2013-06-26 12:58:32 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T48763, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 46763 - ChangeNotificationJob OOMs
ChangeNotificationJob OOMs
Status: VERIFIED FIXED
Product: MediaWiki extensions
Classification: Unclassified
WikidataClient (Other open bugs)
unspecified
All All
: High critical (vote)
: ---
Assigned To: Wikidata bugs
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-04-01 22:17 UTC by Aaron Schulz
Modified: 2013-06-26 12:58 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Aaron Schulz 2013-04-01 22:17:52 UTC
Server: mw1011
URL: http://[unknown-host]
Backtrace:
#0 /usr/local/apache/common-local/php-1.21wmf12/extensions/Wikibase/client/includes/ChangeHandler.php(400): array_merge(Array, Array)
#1 /usr/local/apache/common-local/php-1.21wmf12/extensions/Wikibase/client/includes/ChangeHandler.php(447): Wikibase\ChangeHandler->coalesceChanges(Array)
#2 /usr/local/apache/common-local/php-1.21wmf12/extensions/Wikibase/lib/includes/ChangeNotificationJob.php(151): Wikibase\ChangeHandler->handleChanges(Array)
#3 /usr/local/apache/common-local/php-1.21wmf12/maintenance/runJobs.php(98): Wikibase\ChangeNotificationJob->run()
#4 /usr/local/apache/common-local/php-1.21wmf12/maintenance/doMaintenance.php(110): RunJobs->execute()
#5 /usr/local/apache/common-local/php-1.21wmf12/maintenance/runJobs.php(148): require_once('/usr/local/apac...')
#6 /usr/local/apache/common-local/multiversion/MWScript.php(96): require_once('/usr/local/apac...')
#7 {main}
Comment 1 Sam Reed (reedy) 2013-04-01 22:19:30 UTC
[01-Apr-2013 06:53:09] Fatal error: Allowed memory size of 157286400 bytes exhausted (tried to allocate 71 bytes) at /usr/local/apache/common-local/php-1.21wmf12/extens
ions/Wikibase/client/includes/ChangeHandler.php on line 400
Comment 2 Aaron Schulz 2013-04-11 19:53:03 UTC
The incidence is quite high. It's starting to spam the logs.
Comment 3 Aude 2013-04-11 20:18:17 UTC
https://gerrit.wikimedia.org/r/#/c/58753/ - try reducing the batch size
Comment 4 Aaron Schulz 2013-04-16 06:23:38 UTC
There are less OOMs, but there are still a good number. Like:

Server: mw1001
URL: http://[unknown-host]
Backtrace:
#0 /usr/local/apache/common-local/php-1.22wmf1/includes/Revision.php(1199): gzinflate('?V?r?0?????#??l...')
#1 /usr/local/apache/common-local/php-1.22wmf1/extensions/Wikibase/lib/includes/store/sql/WikiPageEntityLookup.php(293): Revision::getRevisionText(Object(stdClass), 'old_', 'wikidatawiki')
#2 /usr/local/apache/common-local/php-1.22wmf1/extensions/Wikibase/lib/includes/store/sql/WikiPageEntityLookup.php(215): Wikibase\WikiPageEntityLookup->loadEntity('item', Object(stdClass))
#3 /usr/local/apache/common-local/php-1.22wmf1/extensions/Wikibase/lib/includes/store/sql/CachingEntityLoader.php(88): Wikibase\WikiPageEntityLookup->getEntity(Object(Wikibase\EntityId), 25587853)
#4 /usr/local/apache/common-local/php-1.22wmf1/extensions/Wikibase/client/includes/ChangeHandler.php(258): Wikibase\CachingEntityLoader->getEntity(Object(Wikibase\EntityId), 25587853)
#5 /usr/local/apache/common-local/php-1.22wmf1/extensions/Wikibase/client/includes/ChangeHandler.php(373): Wikibase\ChangeHandler->mergeChanges(Array)
#6 /usr/local/apache/common-local/php-1.22wmf1/extensions/Wikibase/client/includes/ChangeHandler.php(399): Wikibase\ChangeHandler->coalesceRuns(Array)
#7 /usr/local/apache/common-local/php-1.22wmf1/extensions/Wikibase/client/includes/ChangeHandler.php(447): Wikibase\ChangeHandler->coalesceChanges(Array)
#8 /usr/local/apache/common-local/php-1.22wmf1/extensions/Wikibase/lib/includes/ChangeNotificationJob.php(151): Wikibase\ChangeHandler->handleChanges(Array)
#9 /usr/local/apache/common-local/php-1.22wmf1/maintenance/runJobs.php(98): Wikibase\ChangeNotificationJob->run()
#10 /usr/local/apache/common-local/php-1.22wmf1/maintenance/doMaintenance.php(110): RunJobs->execute()
#11 /usr/local/apache/common-local/php-1.22wmf1/maintenance/runJobs.php(148): require_once('/usr/local/apac...')
#12 /usr/local/apache/common-local/multiversion/MWScript.php(97): require_once('/usr/local/apac...')
#13 {main}
Comment 5 Aude 2013-04-16 15:34:34 UTC
on my test wiki, I got this out of memory error:

PHP Stack trace:
PHP   1. {main}() /var/www/common/multiversion/multiversion/MWScript.php:0
PHP   2. require_once() /var/www/common/multiversion/multiversion/MWScript.php:86
PHP   3. require_once() /var/www/common/php-master/maintenance/runJobs.php:149
PHP   4. RunJobs->execute() /var/www/common/php-master/maintenance/doMaintenance.php:110
PHP   5. Wikibase\ChangeNotificationJob->run() /var/www/common/php-master/maintenance/runJobs.php:99
PHP   6. Wikibase\ChangeHandler->handleChanges() /var/www/common/php-master/extensions/Wikibase/lib/includes/ChangeNotificationJob.php:151
PHP   7. Wikibase\ChangeHandler->coalesceChanges() /var/www/common/php-master/extensions/Wikibase/client/includes/ChangeHandler.php:462
PHP   8. Wikibase\ChangeHandler->coalesceRuns() /var/www/common/php-master/extensions/Wikibase/client/includes/ChangeHandler.php:411
PHP   9. Wikibase\ChangeHandler->mergeChanges() /var/www/common/php-master/extensions/Wikibase/client/includes/ChangeHandler.php:383
PHP  10. Wikibase\EntityChange::newFromUpdate() /var/www/common/php-master/extensions/Wikibase/client/includes/ChangeHandler.php:279
PHP  11. Wikibase\Entity->getDiff() /var/www/common/php-master/extensions/Wikibase/lib/includes/changes/EntityChange.php:316
PHP  12. Wikibase\Item->entityToDiffArray() /var/www/common/php-master/extensions/Wikibase/DataModel/DataModel/Entity/Entity.php:818
PHP  13. Wikibase\Item->getSiteLinks() /var/www/common/php-master/extensions/Wikibase/DataModel/DataModel/Entity/Item.php:244
PHP  14. Wikibase\SiteLink::newFromText() /var/www/common/php-master/extensions/Wikibase/DataModel/DataModel/Entity/Item.php:128
PHP  15. SiteSQLStore->getSite() /var/www/common/php-master/extensions/Wikibase/DataModel/DataModel/SiteLink.php:59
PHP  16. SiteSQLStore->getSites() /var/www/common/php-master/includes/site/SiteSQLStore.php:244
Comment 6 Aaron Schulz 2013-05-30 21:13:31 UTC
Note that runJobs.php uses a 150mb limit by default.
Comment 7 Andre Klapper 2013-06-13 19:15:46 UTC
Aude's patch in comment 3 got merged, removing keyword.

Is this still an issue?

If so, any idea/proposal how to proceed?
Comment 8 Aaron Schulz 2013-06-14 21:37:53 UTC
Closing, since the practical problem is gone.
Comment 9 abraham.taherivand 2013-06-26 12:58:32 UTC
Verified in Wikidata demo sprint 22-9

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links