Last modified: 2014-02-12 23:54:17 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T48765, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 46765 - missing string in "uploaded via Mobile Web ()."
missing string in "uploaded via Mobile Web ()."
Status: RESOLVED FIXED
Product: MobileFrontend
Classification: Unclassified
stable (Other open bugs)
unspecified
All All
: Lowest minor
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-04-01 23:38 UTC by Sumana Harihareswara
Modified: 2014-02-12 23:54 UTC (History)
10 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Sumana Harihareswara 2013-04-01 23:38:42 UTC
On Commons, when I look at https://commons.wikimedia.org/wiki/File:A_double_rainbow_in_San_Francisco_2013-03-30_21-33.jpg or another image in the category "Uploaded with Mobile/Web", I see a template in the file description telling me:

   This photo was uploaded via Mobile Web ().

Should there be something between those parentheses?

I'm on Firefox 19.0.2 on Ubuntu.

Source code:

<td style="font-size:.85em; padding:.2em; vertical-align:middle">This photo was uploaded via Mobile Web ().</td> 

I've spot-checked about 20 of these images and all their description pages have this template with the same "()".
Comment 1 Jon 2013-04-01 23:41:31 UTC
This is suppose to be the version number but the mobile site doesn't really have a version #.

Template can hopefully be improved to deal with the existing photos that don't use this? Yuvi..?
Comment 2 Sumana Harihareswara 2013-04-01 23:45:15 UTC
From #wikimedia-mobile just now -- it'd be nice if there were a relevant version number in those parentheses (MediaWiki core and/or MediaWiki's MobileFrontend extension), but it's not necessary.

<sumanah> out of curiosity, what's supposed to be in there?
<Maryana> sumanah - yuvi made the template specifically for apps, which come with a version number. that's what that param was for
<Maryana> then we just sorta ganked it for mobile web, but mobile web doesn't have versions :)
<sumanah> (well, technically there are versions, https://commons.wikimedia.org/wiki/Special:Version says MobileFrontend (Version 0.7.0))
<sumanah> & MW 1.21wmf12 (9eafdeb)
<Maryana> i suppose that's true, although version info is less salient for us than for the apps team
Comment 4 Yuvi Panda 2013-04-02 05:13:19 UTC
Should be simple enough to put a conditional there. Will fix later today.
Comment 5 Yuvi Panda 2013-04-02 05:18:03 UTC
Might also be a good time to move it to Lua.

/me plots
Comment 6 Yuvi Panda 2013-04-02 09:36:39 UTC
Too lazy, but did the easy fix. See https://commons.wikimedia.org/w/index.php?title=Template%3AUploaded_from_Mobile%2Fi18n&diff=93821531&oldid=92305218

No more empty parens. 

No more parens!

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links