Last modified: 2013-07-25 09:01:44 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T48775, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 46775 - Make CategoryTree useful without JavaScript
Make CategoryTree useful without JavaScript
Status: PATCH_TO_REVIEW
Product: MediaWiki extensions
Classification: Unclassified
CategoryTree (Other open bugs)
master
All All
: Normal enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-04-02 08:45 UTC by Nick White
Modified: 2013-07-25 09:01 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
0001-Allow-depth-to-be-used-in-category-pages.patch (1.51 KB, patch)
2013-04-02 08:45 UTC, Nick White
Details
0002-Add-config-variable-to-disable-javascript-interface.patch (2.31 KB, patch)
2013-04-02 08:46 UTC, Nick White
Details

Description Nick White 2013-04-02 08:45:59 UTC
Created attachment 12013 [details]
0001-Allow-depth-to-be-used-in-category-pages.patch

Using the 'depth' option, CategoryTree could be quite useful even without the javascript functionality.

For my site I want to display the subcategory hierarchies on category pages, and it's more usable if it's all expanded by default. The level of usability of this varies according to how many categories will be likely to be displayed at once, but certainly for smallish sites like mine it's a big win for usability. It should be an option, anyway.

Attached are two patches:
- Allow-depth-to-be-used-in-category-pages.patch: this allows the 'depth' function to be set for category pages, e.g. with this in LocalSettings.php $wgCategoryTreeCategoryPageOptions = array('mode' => 'all', 'depth' => 4, 'showcount' => 'off');
- Add-config-variable-to-disable-javascript-interface.patch: this adds an option $wgCategoryTreeDisableScript that disables all of the javascript loading.

Taken together, these patches enable the above workflow, where category pages show subcategory hierarchies immediately, without any javascript. I find it useful, and I reckon others would too, so I think these patches should be applied.
Comment 1 Nick White 2013-04-02 08:46:28 UTC
Created attachment 12014 [details]
0002-Add-config-variable-to-disable-javascript-interface.patch
Comment 2 Andre Klapper 2013-04-02 10:43:17 UTC
Hi! Thanks for your patch!

You are welcome to use Developer access
  https://www.mediawiki.org/wiki/Developer_access
to submit this as a Git branch directly into Gerrit:
  https://www.mediawiki.org/wiki/Git/Tutorial

Putting your branch in Git makes it easier to review it quickly.
Thanks again! We appreciate your contribution.
Comment 3 Nick White 2013-04-02 10:54:13 UTC
Done; see https://gerrit.wikimedia.org/r/57041
Comment 4 Andre Klapper 2013-04-02 11:37:12 UTC
Thanks!

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links