Last modified: 2014-02-06 11:12:59 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T48792, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 46792 - Gerrit should include summaries of and links to inline comments in the cover comment
Gerrit should include summaries of and links to inline comments in the cover ...
Status: NEW
Product: Wikimedia
Classification: Unclassified
Git/Gerrit (Other open bugs)
wmf-deployment
All All
: Unprioritized normal (vote)
: ---
Assigned To: Nobody - You can work on this!
https://code.google.com/p/gerrit/issu...
: upstream
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-04-02 15:18 UTC by Isarra
Modified: 2014-02-06 11:12 UTC (History)
10 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Isarra 2013-04-02 15:18:12 UTC
If the inline comments were included (or had an option to be included) in the main cover comment, it'd be a lot easier to follow them. Links to the specific patchset file position in which they are placed would also make it a lot easier to get to them.

As it is (2 inline comments) just is not that useful.
Comment 1 spage 2013-04-08 23:33:14 UTC
The workflow is especially difficult when you have responded to existing comments on Patch Set N and then someone new comments on the same patch set.  It seems the best you can do is visit every file in the patch set that has comments and Ctrl+F/Ctrl+G to search for the new reviewer's name.
Comment 2 Nemo 2014-02-06 08:49:42 UTC
Allegedly fixed upstream (2.9)! \o/ https://code.google.com/p/gerrit/issues/detail?id=93
Worth running any exploding non-stable version or sacrificing entire herds of scapegoats just to have this one feature, IMHO.
Comment 3 Nemo 2014-02-06 09:07:51 UTC
I had noticed it was backported to 2.8 but not which point version; Legoktm points out you have to "switch to the new change screen in your prefs" (i.e. https://gerrit.wikimedia.org/r/#/settings/preferences "Change View:"). http://cl.ly/image/0C3e1v0m1u2O
I suppose this bug will be fixed (only) when our server is switched to the new change view then? (And I understood we're not going to do so that soon if ever.)
Comment 4 Bartosz Dziewoński 2014-02-06 11:12:59 UTC
The new change view has some problems, yeah, but IMO it's an improvement over the current one – it just needs some polish. I switched to it already :)

There is a list of problems with new change view on at http://etherpad.wikimedia.org/p/new-gerrit-change-view-comments (I started it, Legoktm and Isarra contributed), feel free to add items or file them upstream.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links