Last modified: 2013-04-16 21:29:56 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T48794, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 46794 - VisualEditor: Add whitespace skipping to UnicodeJS.wordbreak for word skipping functionality
VisualEditor: Add whitespace skipping to UnicodeJS.wordbreak for word skippin...
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
ContentEditable (Other open bugs)
unspecified
All All
: Unprioritized normal
: VE-deploy-2013-04-29
Assigned To: Inez Korczyński
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-04-02 15:31 UTC by Ed Sanders
Modified: 2013-04-16 21:29 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Ed Sanders 2013-04-02 15:31:22 UTC
Currently we can't use the UnicodeJS.wordbreak library to emulate word skipping (ctrl+arrow / alt+arrow) functionality as wordbreaks appear either side of whitespace and between multiple whitespaces:

|One| |Two| | |Three|

Moving forwards we expect the cursor to stop in the following positions:
One| Two| Three|

Moving backwards we expect:
|One |Two |Three
Comment 1 Ed Sanders 2013-04-02 15:32:22 UTC
Looking at other implementations, sepcifically OpenOffice, they have an "ignore whitespace" mode in their nextWord function:

https://svn.apache.org/repos/asf/incubator/ooo/symphony/trunk/main/i18npool/source/breakiterator/breakiterator_unicode.cxx

which calls an is_whitepsace function, which is defined as:
http://www.icu-project.org/apiref/icu4c/uchar_8h.html#a5cef869b23e8d8e649963457cccca68e
Comment 2 Inez Korczyński 2013-04-03 21:29:43 UTC
I have added better support for skipping white spaces in 4th patch set: https://gerrit.wikimedia.org/r/#/c/57076/
Comment 3 Inez Korczyński 2013-04-03 22:50:13 UTC
Actually Ed is still working on it.
Comment 4 Gerrit Notification Bot 2013-04-12 11:17:13 UTC
Related URL: https://gerrit.wikimedia.org/r/58868 (Gerrit Change I6b2700d65476c4d34ba4a01a88382d7af8e736fb)
Comment 5 James Forrester 2013-04-16 20:03:44 UTC
Now fixed.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links