Last modified: 2013-04-04 06:52:11 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T48857, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 46857 - OutputPage: Inline module state for site/user module stuck in "loading" if module is filtered out
OutputPage: Inline module state for site/user module stuck in "loading" if mo...
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
ResourceLoader (Other open bugs)
1.21.x
All All
: Normal normal (vote)
: 1.21.0 release
Assigned To: Krinkle
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2013-04-03 20:12 UTC by Krinkle
Modified: 2013-04-04 06:52 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Krinkle 2013-04-03 20:12:41 UTC 
OutputPage::getScriptsForBottomQueue sets state=loading if $wgUseSiteJs = true, and adds result of calling makeResourceLoaderLink() to the $scripts list.

However there is a case where makeResourceLoaderLink() will return an empty string (instead of a script tag loading the scripts of the site module) - namely the filter loop in makeResourceLoaderLink() rejects it, which is the case on pages like SpcialJavaScriptTest, SpecialPreferences and others that disallow modules from the user land.
Comment 1 Krinkle 2013-04-03 20:57:08 UTC 
Change-Id: I46b5bc6f714abe4b66186d7b7a14c69195f00ee1
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links