Last modified: 2013-04-09 11:16:59 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T48895, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 46895 - VisualEditor: ve.getHash custom hashes are double-hashed
VisualEditor: ve.getHash custom hashes are double-hashed
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
Data Model (Other open bugs)
unspecified
All All
: High normal
: VE-deploy-2013-04-15
Assigned To: Ed Sanders
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-04-04 14:50 UTC by Ed Sanders
Modified: 2013-04-09 11:16 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Ed Sanders 2013-04-04 14:50:10 UTC
Our current setup for custom hashing objects to to give them a method .getHash() which looks like this:

T.prototype.getHash = function () {
  var someSubsetOfT = // code here
  return ve.getHash( someSubsetOfT );
}

and to invoke we use

 ve.getHash( instanceOfT );

However ve.getHash( instanceOfT ) === ve.getHash( ve.getHash( someSubsetOfT ) )
which isn't really what we want.

One solution would be to rename getHash to getHashableObject (or something) and have it return just someSubsetOfT directly.
Comment 1 Gerrit Notification Bot 2013-04-08 22:30:26 UTC
Related URL: https://gerrit.wikimedia.org/r/58235 (Gerrit Change If11071d4b04a01e25102ffb57240882f650ee10d)
Comment 2 Gerrit Notification Bot 2013-04-08 23:17:03 UTC
Related URL: https://gerrit.wikimedia.org/r/58241 (Gerrit Change I6a9b42facd97fbf49042d3a082121ec93659b9f1)
Comment 3 James Forrester 2013-04-09 01:04:10 UTC
Ed, did you re-open because there's more to do, or because Jenkins dying meant the changes weren't merged? :-)
Comment 4 Ed Sanders 2013-04-09 11:16:59 UTC
Reopened for 58241, but now that is done am closing again.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links