Last modified: 2013-06-10 03:31:04 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T48930, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 46930 - changeTitle() creates redirects even in case of redirid == 0
changeTitle() creates redirects even in case of redirid == 0
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
Semantic MediaWiki (Other open bugs)
unspecified
All All
: Unprioritized normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-04-05 18:20 UTC by MWJames
Modified: 2013-06-10 03:31 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description MWJames 2013-04-05 18:20:27 UTC
Title:moveTo() explicitly sets createRedirect to false (redirid == 0) SMWSQLStore3Writers::changeTitle() never checks the redirid therefore smw_fpt_redi contains gost redirects for pages with (Special:MovePage - > Leave a redirect behind unchecked)

There are two approaches to change this behaviour:

1) Execute updateRedirects() only when $redirid != 0 which will means that all possible existing associations with a moved page are also gone or

2) Execute updateRedirects() in all cases (copying associations with the moved page) but in case of $redirid == 0 execute doDataUpdate( $oldtitle ) in order for the oldTitle (which got deleted) to delete the container for the oldTitle object as well.

## Note
The hook ArticleDelete is not called for a moved oldTitle therefore deleteSubject() is also not called which means the container for oldTitle still has a references to the newTitle (see smw_fpt_redi).

## Example
See [1], [2] where [1] is delete but shows semantic data from [2]. When looking at "Has query" property reveals that Demo:Foo has suddenly elements of Demo:Foo2.

[1] http://www.semantic-mediawiki.org/wiki/Special:Browse/Demo:Foo
[2] http://www.semantic-mediawiki.org/wiki/Special:Browse/Demo:Foo2
Comment 1 Gerrit Notification Bot 2013-04-05 18:21:11 UTC
Related URL: https://gerrit.wikimedia.org/r/57757 (Gerrit Change Ibad8cd133cc985656346769787698a8519f5e58e)
Comment 2 Gerrit Notification Bot 2013-05-15 16:14:50 UTC
https://gerrit.wikimedia.org/r/57757 (Gerrit Change Ibad8cd133cc985656346769787698a8519f5e58e) | change APPROVED and MERGED [by jenkins-bot]

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links