Last modified: 2013-04-10 11:55:02 UTC
Error in \extensions\SemanticMediaWiki\includes\SMW_Infolink.php [352] encodeParameters() --------------------------- Description: {{#ask:[[Article::+]] [[Full name::+]] |?# |?Full name=fullname |?Photo=photo |?Source=cource |?Anchor=anchor |?Author=author |?Description=text |limit=1 |format=template |link=none |headers=hide |mainlabel=page |searchlabel=… next results |named args=1 |template=Article }} Result: ...text... ...text... ...text... [http://wiki.mirsimpatov.net/index.php?title=%D0%A1%D0%BB%D1%83%D0%B6%D0%B5%D0%B1%D0%BD%D0%B0%D1%8F:Ask&x=-5B-5B%D0%A0%D0%B0%D0%B7%D0%BC%D0%B5%D1%80-20%D1%81%D1%82%D0%B0%D1%82%D1%8C%D0%B8%3A%3A-3C5000-5D-5D-20-20-5B-5B%D0%A6%D0%B8%D1%82%D0%B0%D1%82%D0%B0-2F%D0%A1%D0%B2%D0%BE%D0%B9%D1%81%D1%82%D0%B2%D0%B0%3A%3A%2B-5D-5D-20-5B-5B%D0%98%D0%BD%D1%82%D0%B5%D1%80%D0%B5%D1%81%D0%BD%D0%BE%D0%B5-20%D0%BF%D0%BE-20%D1%82%D0%B5%D0%BC%D0%B5%3A%3A%2B-5D-5D%2F-3F%3D%D1%81%D1%82%D1%80%D0%B0%D0%BD%D0%B8%D1%86%D0%B0-23%2F-3F-23-2D%2F-3F%D0%9F%D0%BE%D0%BB%D0%BD%D0%BE%D0%B5-20%D0%BD%D0%B0%D0%B7%D0%B2%D0%B0%D0%BD%D0%B8%D0%B5%3D%D0%BD%D0%B0%D0%B7%D0%B2%D0%B0%D0%BD%D0%B8%D0%B5%2F-3F%D0%A4%D0%BE%D1%82%D0%BE%3D%D1%84%D0%BE%D1%82%D0%BE%2F-3F%D0%9E%D0%B7%D0%92%3D%D1%80%D0%B5%D0%B7%D0%BE%D0%BD%D0%B8%D1%80%D1%83%D0%B5%D1%82%2F-3F%D0%98%D1%81%D1%82%D0%BE%D1%87%D0%BD%D0%B8%D0%BA%3D%D0%B8%D1%81%D1%82%D0%BE%D1%87%D0%BD%D0%B8%D0%BA%2F-3F%D0%A1%D1%81%D1%8B%D0%BB%D0%BA%D0%B0%3D%D1%81%D1%81%D1%8B%D0%BB%D0%BA%D0%B0%2F-3F%D0%90%D0%B2%D1%82%D0%BE%D1%80%3D%D0%B0%D0%B2%D1%82%D0%BE%D1%80%2F-3F%D0%9E%D0%BF%D0%B8%D1%81%D0%B0%D0%BD%D0%B8%D0%B5%3D%D1%82%D0%B5%D0%BA%D1%81%D1%82%2F-3F%D0%98%D0%BD%D1%82%D0%B5%D1%80%D0%B5%D1%81%D0%BD%D0%BE%D0%B5-20%D0%BF%D0%BE-20%D1%82%D0%B5%D0%BC%D0%B5%3D%D1%82%D0%B5%D0%BC%D1%8B%2F-3F%D0%92%D0%B8%D0%B4-20%D0%9E%D0%B7%D0%A4%D0%B0%3D%D0%B2%D0%B8%D0%B4%D1%8B%D0%9E%D0%B7%D0%A4%D0%B0&format=template&limit=1&link=none&headers=hide&mainlabel=%D1%81%D1%82%D1%80%D0%B0%D0%BD%D0%B8%D1%86%D0%B0&searchlabel=%E2%80%A6%20%D1%81%D0%BB%D0%B5%D0%B4%D1%83%D1%8E%D1%89%D0%B8%D0%B5%20%D1%80%D0%B5%D0%B7%D1%83%D0%BB%D1%8C%D1%82%D0%B0%D1%82%D1%8B&template=%D0%A6%D0%B8%D1%82%D0%B0%D1%82%D0%B0%2F%D0%A1%D1%82%D0%B0%D1%82%D1%8C%D1%8F&named args=1&offset=1 … next results] --------------------------- Link to the next results appear as follows: <a href="...">args=1&offset=1 … next results</a> --------------------------- Spaces in the link must be encoded: named args => named%20args
Resolving: 395: $value = $name . '=' . rawurlencode( $value ); => 395: $value = rawurlencode($name) . '=' . rawurlencode( $value );
Related URL: https://gerrit.wikimedia.org/r/58077 (Gerrit Change I5f0a51a9f4428cd3976ab7d0f55af66ea3fb0df7)
https://gerrit.wikimedia.org/r/#/c/58077/ Thanks for the patch - just submitted it to gerrit
Related URL: https://gerrit.wikimedia.org/r/58080 (Gerrit Change Ic15c0f9c3ce40bddeda65cab0200584054a0506e)
Another error in decodeParameters() $wgRequest->getValues(); ["named_args"]=1 must be ["named args"]=1 Resolving: 446: $result = $wgRequest->getValues(); => 446: foreach ($wgRequest->getValues() as $key => $value) { 447: $result[str_replace( '_', ' ', $key)] = $value; 448: }
https://gerrit.wikimedia.org/r/58080 (Gerrit Change Ic15c0f9c3ce40bddeda65cab0200584054a0506e) | change APPROVED and MERGED [by jenkins-bot]
I merged a regression test for the first issue. Please enhance the test if necessary for other parameter encoding/decoding issues.
