Last modified: 2013-04-10 08:59:26 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T49019, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 47019 - [TUX] [IE10] No translation displayed and all page loads indicate unsaved changes
[TUX] [IE10] No translation displayed and all page loads indicate unsaved cha...
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
Translate (Other open bugs)
master
All All
: High blocker (vote)
: ---
Assigned To: Santhosh Thottingal
https://translatewiki.net/w/i.php?tit...
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-04-08 19:10 UTC by Siebrand Mazeland
Modified: 2013-04-10 08:59 UTC (History)
6 users (show)

See Also:
Web browser: Internet Explorer
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Siebrand Mazeland 2013-04-08 19:10:02 UTC
Observed on IE10 on a local Windows 7 NL. Confirmed on crossbrowsertesting.com with IE10 on Windows 8.

The editor is totally broken. 

Steps to reproduce:
1. Go to URL

Observed:
I. First displayed message ("Translating:Statistics") is marked as translated.

2. Open the editor by clicking on "Translating:Statistics"

Observed:
II. An empty editor is displayed.

Expected:
III. An editor with the current translation is displayed.

3. Close the editor

Observed:
IV. Message is marked as unsaved.

Expected:
V. Unchanged translations are not marked as unsaved.

4. Force reload the page.

Observed:
VI. A pop-up is displayed with the message "Are you sure you want to leave this page?"

Expected:
VII. No pop-up, as nothing was changed, and the page reloads.

5. Click "leave this page" to reload it.
6. Force reload the page again.

Observed:
VIII. A pop-up is displayed with the message "Are you sure you want to leave this page?"

Expected:
IX. No pop-up, as nothing was changed, and the page reloads.
Comment 1 Gerrit Notification Bot 2013-04-08 20:48:29 UTC
Related URL: https://gerrit.wikimedia.org/r/58217 (Gerrit Change I05f169f8883ac7f30f38cd5cb16f3eab2fe4100c)
Comment 2 Amir E. Aharoni 2013-04-08 21:37:04 UTC
The first two issues should be solved by
https://gerrit.wikimedia.org/r/#/c/58217/

The issue with the pop-up on closing and reloading probably has something to with the .on( 'input propertychange', function () etc. bindings on the textarea in ext.translate.editor.js. There are two of them for some reason and they are doing strange things with the mw.translate.dirty flag.
Comment 3 Santhosh Thottingal 2013-04-09 05:53:56 UTC
IE<9 does not support oninput. So we used propertychange, but that will get triggered not only in content change, but in some DOM changes too. That might be the cause for wrong dirty bits. IE 9+ support oninput but it is buggy- does not detect text removal etc. So we need to write a cross browser event for this. That should fix all issues(3 to 6). Working on it.
Comment 4 Siebrand Mazeland 2013-04-09 07:28:46 UTC
With Gerrit change #58217, expected behaviors III and V are displayed. Expected behaviors VII and IX are not observed (VI and XIII instead).
Comment 5 Siebrand Mazeland 2013-04-09 08:03:16 UTC
Additional information: Step 4 and 6 do display expected behavior in IE9.
Comment 6 Gerrit Notification Bot 2013-04-09 09:10:07 UTC
Related URL: https://gerrit.wikimedia.org/r/58287 (Gerrit Change Ib5a7fecdf3cc42c7f5463bb03cae2326e1a3afbc)
Comment 7 Amir E. Aharoni 2013-04-10 08:59:26 UTC
Tested on IE10 and other browsers, working.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links