Last modified: 2014-10-10 16:37:04 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T49027, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 47027 - Implement connection timeout in MediaWiki's Http class
Implement connection timeout in MediaWiki's Http class
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
General/Unknown (Other open bugs)
1.21.x
All All
: High enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-04-08 23:26 UTC by Asher Feldman
Modified: 2014-10-10 16:37 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Asher Feldman 2013-04-08 23:26:00 UTC
MWHttpRequest currently sets CURLOPT_TIMEOUT ($this->curlOptions[CURLOPT_TIMEOUT] = $this->timeout;) but doesn't provide a way to set CURLOPT_CONNECTTIMEOUT_MS.  

MWSearch as deployed in production has a 10 second timeout.  Today we had an outage where lsearchd was up on servers but hung and apaches waited 10 seconds for the connection attempts to timeout.  It would be better if search connection attempts timed out at 500-1000ms.
Comment 1 Gerrit Notification Bot 2013-04-08 23:45:42 UTC
Related URL: https://gerrit.wikimedia.org/r/58247 (Gerrit Change I6e64a8bfc58e899149463d305eac672c1e8ad2ba)
Comment 2 Sam Reed (reedy) 2013-04-08 23:48:14 UTC
http://php.net/manual/en/function.curl-setopt.php

CURLOPT_TIMEOUT
The maximum number of seconds to allow cURL functions to execute.	

CURLOPT_TIMEOUT_MS
The maximum number of milliseconds to allow cURL functions to execute. If libcurl is built to use the standard system name resolver, that portion of the connect will still use full-second resolution for timeouts with a minimum timeout allowed of one second.

Added in cURL 7.16.2. Available since PHP 5.2.3.
Comment 3 Chad H. 2013-04-08 23:49:35 UTC
We already support CURLOPT_TIMEOUT. This is about supporting CURLOPT_CONNECTTIMEOUT_MS, which is what my patch does.
Comment 4 Gerrit Notification Bot 2013-06-05 15:37:51 UTC
Related URL: https://gerrit.wikimedia.org/r/67095 (Gerrit Change I3e2a84ee8a759dd2bdb2fd0837e0cd5605541816)
Comment 5 Andre Klapper 2014-09-21 21:42:15 UTC
https://gerrit.wikimedia.org/r/#/c/67095/ was merged ages ago.

Is more work needed here, or can this be closed?
Comment 6 Andre Klapper 2014-10-10 16:37:04 UTC
No reply to comment 5. Assuming this bug is FIXED.
If that is not the case: Please reopen and elaborate what is left to do here to get this report fixed.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links