Last modified: 2013-04-10 14:11:00 UTC
Description: Ask: [[Qoute/Properties::+]] [[Author::!Boris Pasternak]] is not working properly, because spaces is replaced by an underscore Resolving: \includes\storage\SQLStore\SMW_SQLStore3_Queries.php 542: $value = $description->getDataItem()->getSortKey(); => 542: $value = str_replace("_", " ", $description->getDataItem()->getSortKey()); \includes\storage\compatSQLStore\SMW_SQLStore2_Queries.php 507: $value = $description->getDataItem()->getSortKey(); => 507: $value = str_replace("_", " ", $description->getDataItem()->getSortKey());
The space should not be replaced by an underscore IMO; not sure where this is happening now, or why. On first glance, this does not seem to be the correct place to fix it.
>> The space should not be replaced by an underscore In my opinion, it makes sense, because the type of properties - Page.
Thinking about it more, this is certainly not the correct place. The DataItem should return the correct form of the sort key. Furthermore the proposed fix is wrong, as it will also replace underscores in strings and whatnot, where this leads to an alternate value.
Related URL: https://gerrit.wikimedia.org/r/58513 (Gerrit Change I972d99c2586026d33e9c4df2b56e5467c8728694)
The above change is only a test case to verify expected results in the AskParserFunction class (it doesn't prove/disapprove of the issue, only ensures a query string with spaces is tested).
