Last modified: 2013-04-12 09:48:28 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T49077, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 47077 - quality status of page using <pages tag doesn't match the expected status
quality status of page using <pages tag doesn't match the expected status
Status: RESOLVED WORKSFORME
Product: MediaWiki extensions
Classification: Unclassified
ProofreadPage (Other open bugs)
master
All All
: High normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-04-10 15:02 UTC by Philippe Elie
Modified: 2013-04-12 09:48 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Philippe Elie 2013-04-10 15:02:55 UTC
http://fr.wikisource.org/wiki/%C3%80_un_martyr transclude six page with a <pages index="..." from=77 to=82, these six pages are marked as not proofread, the quality status should be red (under the page title). But actually the quality status is the status of the whole book not only the status of these six pages. As a side effect saving a page is very slow as the query to get the status is heavy. This behavior doesn't occur on en.wikisource.org.
Comment 1 Andre Klapper 2013-04-10 15:48:46 UTC
Are there other examples of this? 
Are there indicators that this a new behavior?
Asking a I don't yet see how this issue is highest priority and critical.
Comment 2 Tpt 2013-04-10 17:02:42 UTC
In order to get the quality status of Page: pages transcluded in a ns0 page, Proofread Page get the status of all Page: listed in the templatelinks table by getting for each ones the relevant quality category (see
https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/extensions/ProofreadPage.git;a=blob;f=ProofreadPage.body.php;h=820116e5e192af272f92abdb8405793be1807c11;hb=23423c096581f1e6bc36a84115d4dc44253d1645#l1715 ).

But not only pages directly transcluded in the current page are in this table but also pages transcluded in a page transcluded in the current page, that cause to have too much pages as needed in the bar.

After some investigation, this issue is not really new and the number of pages affected is low, so I reduce the severity to "normal".

An other example: https://fr.wikisource.org/wiki/Les_Boh%C3%A9miens_%28B%C3%A9ranger%29 (the quality status should be completely green)
Comment 3 Philippe Elie 2013-04-11 17:21:29 UTC
We tracked our trouble to the use in a module of frame:preprocess() with the frame of the page calling a template which invoke the module, some uneeded evaluation of template argument was done as a side effect of the call to preprocess(). We solved that by using frame:newChild(title = ..., args = {}) to create an empty frame.
Comment 4 Andre Klapper 2013-04-12 09:48:28 UTC
Thanks for sharing the workaround here!

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links