Last modified: 2013-04-22 16:15:09 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T49131, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 47131 - Make sure notification counts are reset after user changes subscription options
Make sure notification counts are reset after user changes subscription options
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
Echo (Other open bugs)
unspecified
All All
: Unprioritized normal (vote)
: ---
Assigned To: Ryan Kaldari
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2013-04-11 17:26 UTC by Ryan Kaldari
Modified: 2013-04-22 16:15 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Ryan Kaldari 2013-04-11 17:26:00 UTC 
Not sure if this is handled yet, when a notification type is dismissed from either the preference page or notification page, the notification count reset function should be called so a new count would be generated.
Comment 1 Ryan Kaldari 2013-04-12 21:06:08 UTC 
Whether this is done through the prefs or the options API, the change is handled by User::saveSettings() which does clear the user cache.
Comment 2 Gerrit Notification Bot 2013-04-12 22:13:04 UTC 
Related URL: https://gerrit.wikimedia.org/r/59016 (Gerrit Change I5244ef9f7bf9d1217c0c0df6691d8cf689c47cf5)
Comment 3 Ryan Kaldari 2013-04-12 22:17:07 UTC 
Forgot about the count itself needing to be updated, besides the cache. Fixed in 59016 (linked above).
Comment 4 Andre Klapper 2013-04-12 22:29:44 UTC 
-> "patch-in-gerrit" (patch-need-review is only for patches in Bugzilla)
Comment 5 Ryan Kaldari 2013-04-12 22:32:02 UTC 
Shit, I've been doing it wrong this whole time :P
Comment 6 Alex Monk 2013-04-12 22:43:43 UTC 
Merged.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links