Last modified: 2013-06-05 13:58:39 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T49133, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 47133 - Some api responses do not contain coordinates even when you provide a colimit parameter
Some api responses do not contain coordinates even when you provide a colimit...
Status: REOPENED
Product: MediaWiki extensions
Classification: Unclassified
GeoData (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-04-11 18:40 UTC by Jon
Modified: 2013-06-05 13:58 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Jon 2013-04-11 18:40:11 UTC
Some api responses e.g. http://en.m.wikipedia.org/w/api.php?format=json&action=query&prop=pageimages%7Ccoordinates&pithumbsize=180&pilimit=50&generator=geosearch&ggscoord=37.78670760000001%7C-122.39959539999998&ggsradius=10000&ggsnamespace=0&ggslimit=50&_=1365705318404

do not return coordinates in the results
In this specific example the following is returned:
"4574532":{"pageid":4574532,"ns":0,"title":"Palace Hotel, San Francisco","thumbnail":{"source":"http://upload.wikimedia.org/wikipedia/commons/thumb/9/95/Palace_Hotel_and_Lotta%27s_Fountain.jpg/180px-Palace_Hotel_and_Lotta%27s_Fountain.jpg","width":180,"height":135},"pageimage":"Palace_Hotel_and_Lotta's_Fountain.jpg"}

Expected: if there are no coordinates it shouldn't appear in the response
Comment 2 Jon 2013-04-15 16:56:26 UTC
What does colimit=max do?!

Although this solves my problem these oddities make our API harder to consume/understand so I still think there is a bug here in that we should probably provide a default value for 'colimit' thus reopening.
Comment 3 Max Semenik 2013-04-15 18:38:06 UTC
That's how our API works, all query modules have their own limits independent of other modules used in the same query.
Comment 4 Jon 2013-04-16 16:29:36 UTC
Well that's dumb (especially in this place... really 3 limits in a query...?!?) and every time we resolve such a ticket as invalid we are missing an opportunity to make the API more developer friendly to the people who have the desire to use it.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links