Last modified: 2013-11-25 10:28:33 UTC
1. When a table is collapsed, the caption remains visible. It should be hidden too, as part of the table’s content. (I’m referring to the table’s <caption> element, not the first table row where the collapse button resides.) 2. If the customToggle is placed within the table caption, it fails to work. It should be made to work in this case, and in this case the table should collapse and leave the caption visible instead of the first row.
Thanks for taking the time to report this! Is there any testcase available for this?
Test cases: http://en.wiktionary.org/wiki/User:Mzajac/jQuery.makeCollapsible_in_table_captions Feel free to edit the page to add more tests, correct my errors, or whatever.
This should be easy enough; +easy.
Change 96773 had a related patch set uploaded by Areke: jQuery.makeCollapsible: Allow support for table captions https://gerrit.wikimedia.org/r/96773
Change 96773 abandoned by Bartosz Dziewoński: jQuery.makeCollapsible: Allow support for table captions Reason: The GCI task [1] was unclaimed. If you want to continue working on this, click the "Restore Change" button. [1] https://www.google-melange.com/gci/task/view/google/gci2013/5808344656773120 https://gerrit.wikimedia.org/r/96773
Change 97348 had a related patch set uploaded by Theopolisme: jquery.makeCollapsible: collapse to caption support https://gerrit.wikimedia.org/r/97348
@Michael, I've written (/am working on) a patch for this that follows the following logic -- could you let me know if it seems okay? If the table has a caption, collapse to the caption, rather than the first row. __ Expanded state __ Caption [collapse] Text Text More text Text and stuff __ Collapsed state __ Caption [expand]
That looks great!
Change 97348 merged by jenkins-bot: jquery.makeCollapsible: collapse to caption support https://gerrit.wikimedia.org/r/97348
Done. Thanks!
