Last modified: 2014-06-26 23:08:46 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T49260, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 47260 - Jenkins: repositories missing a .jshintrc file are failing
Jenkins: repositories missing a .jshintrc file are failing
Status: RESOLVED INVALID
Product: Wikimedia
Classification: Unclassified
Continuous integration (Other open bugs)
wmf-deployment
All All
: Low normal (vote)
: ---
Assigned To: Krinkle
https://gerrit.wikimedia.org/r/#/c/59...
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-04-15 21:15 UTC by Raimond Spekking
Modified: 2014-06-26 23:08 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Raimond Spekking 2013-04-15 21:15:07 UTC
Jenkins: jslint fails for some extensions and therefore translatewiki script breaks.
Comment 1 Antoine "hashar" Musso (WMF) 2013-04-15 21:19:20 UTC
AbuseFilter jslint job failed : https://integration.wikimedia.org/ci/job/mwext-AbuseFilter-jslint/80/

Although the previous patchset ( https://gerrit.wikimedia.org/r/#/c/58755/ ) has been merged by the gate-and-submit pipeline (ie test used to work).
Comment 2 Chad H. 2013-04-16 15:12:42 UTC
Moving from Git/Gerrit to Continuous Integration.
Comment 3 Krinkle 2013-05-13 16:54:15 UTC
The immediate problem has been fixed by adding the files to the extensions that had jshint enabled but were missing a jshintrc file.

For the future I'll add a check in the jenkins job asserting that a jshint configuration file exists before proceeding, that way the error will be "Missing .jshintrc file" instead of some arbitrary style violation that comes from the internal jshint defaults.
Comment 4 Antoine "hashar" Musso (WMF) 2013-08-28 08:23:30 UTC
That would apply to any repositories. Updating summary.
Comment 5 Antoine "hashar" Musso (WMF) 2013-09-03 13:02:25 UTC
I think the jobs started failing when we added a .jshintrc file in integration/docroot.git and/or had the Jenkins workspace has children of /srv/ . That is bug 52456.
Comment 6 Krinkle 2014-06-26 23:08:46 UTC
Projects that have jshint enabled must have a jshintrc file that contains actual rules (not something silly like {}).

If you don't have jshintrc, please don't enable jshint in Jenkins.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links