Last modified: 2014-05-05 12:42:58 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T49283, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 47283 - Reduce memory footprint of Change objects by zipping diffs
Reduce memory footprint of Change objects by zipping diffs
Status: NEW
Product: MediaWiki extensions
Classification: Unclassified
WikidataClient (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Wikidata bugs
u=dev c=backend p=0
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-04-16 13:49 UTC by Daniel Kinzler
Modified: 2014-05-05 12:42 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Daniel Kinzler 2013-04-16 13:49:36 UTC
This is to alleviate the issue raised by bug 46763, namely that ChangeNotificationJob runs out of memory when trying to load (hundreds of thousands of) Change objects from the database.

A considerable amount of memory may be taken up by the diff contained in the Change object, especially if the change is not an atomic edit but a complex edit (from a bot, or a big undo, etc). 

To reduce the memory footprint, the diff should only be unserialized on demand, and the unserialized version should not be kept around (or only be kept in the Change object if this was explicitly requested, for speed).

In addition, the (serialized) diff should be compressed (if larger than some constant minimum, refer to our memcached interface for reference).
Comment 1 Daniel Kinzler 2013-04-16 13:51:24 UTC
Gah, where's the edit button?! That is supposed to be "hundreds *or* thousands" of Change objects.
Comment 2 Andre Klapper 2013-04-17 09:47:36 UTC
(In reply to comment #1)
> Gah, where's the edit button?!

In https://bugzilla.mozilla.org/show_bug.cgi?id=40896

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links