Last modified: 2013-04-22 16:15:49 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T49291, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 47291 - Cloned Cite object does not clear if the parser was cloned inside a <ref> or <references>
Cloned Cite object does not clear if the parser was cloned inside a <ref> or ...
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
Cite (Other open bugs)
master
All All
: Unprioritized normal (vote)
: ---
Assigned To: Brad Jorsch
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2013-04-16 19:52 UTC by Brad Jorsch
Modified: 2013-04-22 16:15 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Brad Jorsch 2013-04-16 19:52:40 UTC 
If the parser is cloned inside a <ref> or <references> tag (e.g. if the first call to MessageCache::getParser() in the page is due to a message inside one of those tags), then the cloned Cite object created in Cite::cloneState() will have mInRef or mInReferences true and therefore the call to Cite::clearState() will not actually clear the Cite object.
Comment 1 Gerrit Notification Bot 2013-04-16 19:52:58 UTC 
Related URL: https://gerrit.wikimedia.org/r/59508 (Gerrit Change Id3e91c41dc33a703b5326961fd57e1fe8ac61f5b)
Comment 2 Gerrit Notification Bot 2013-04-16 20:15:28 UTC 
https://gerrit.wikimedia.org/r/59508 (Gerrit Change Id3e91c41dc33a703b5326961fd57e1fe8ac61f5b) | change APPROVED and MERGED [by Aaron Schulz]
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links