Last modified: 2014-02-12 23:45:22 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T49330, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 47330 - Make MobileFrontend use mediawiki.ui button styles
Make MobileFrontend use mediawiki.ui button styles
Status: RESOLVED WONTFIX
Product: MobileFrontend
Classification: Unclassified
Feature requests (Other open bugs)
unspecified
All All
: Low enhancement
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-04-17 19:06 UTC by Munaf Assaf
Modified: 2014-02-12 23:45 UTC (History)
9 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Munaf Assaf 2013-04-17 19:06:08 UTC
Jon Robson requested that we track this in a different bug (we were previously discussing it in #46804, which is focused on button heights).

There are several buttons scattered throughout MobileFrontend that aren't using the latest mediawiki.ui buttons which can be found in MW core. In general, button styles are inconsistently applied in MobileFrontend and we need to make sure that errant styles aren't tweaking things.

See #46804 for a specific example and related discussion.
Comment 1 Jon 2013-05-08 14:39:52 UTC
mediawiki.ui.default.css seems to use classes such as .mw-ui-button
In MobileFrontend we simply style the button tag to keep things simpler.

Do we want to add classes such as mw-ui-button?

Marking as enhancement for time being.
Comment 2 Jon 2013-06-05 19:17:24 UTC
Thinking about this some more a long term goal might be to use the same mixins to generate the button styles. I'm not sure however what advantage this has at the moment and since the source files used to generate css for mediawiki.ui buttons is written in Sass and we use Less this will take some time.

Since I don't see the real advantage at this time (the Vector skin and the Minerva skin are very different) I think doing this would not be of value to either projects - Vector needs more specific css rules and cares about IE6, Minerva needs more minimal ones and doesn't care so much about IE6.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links