Last modified: 2013-04-18 23:22:14 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T49339, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 47339 - beta cluster: wrong MessagesEn.php file?
beta cluster: wrong MessagesEn.php file?
Status: RESOLVED FIXED
Product: Wikimedia Labs
Classification: Unclassified
deployment-prep (beta) (Other open bugs)
unspecified
All All
: Unprioritized normal
: ---
Assigned To: Nobody - You can work on this!
: browser-test-bug
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-04-17 22:21 UTC by Chris McMahon
Modified: 2013-04-18 23:22 UTC (History)
7 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
wrong string on failed login on beta (42.51 KB, image/png)
2013-04-17 22:21 UTC, Chris McMahon
Details
Difference in feedback messages (341.59 KB, image/png)
2013-04-18 13:00 UTC, Željko Filipin
Details
username or user name (338.14 KB, image/png)
2013-04-18 13:12 UTC, Željko Filipin
Details
password (351.79 KB, image/png)
2013-04-18 13:17 UTC, Željko Filipin
Details

Description Chris McMahon 2013-04-17 22:21:28 UTC
Created attachment 12130 [details]
wrong string on failed login on beta

Attempt to login with a an incorrect username.  Error message contains the string "User names are case sensitive".  However, the string should be "Usernames are case sensitive".  (No space between "User" and "names")

Line 1129 of the file at @deployment-bastion:/usr/local/apache/common/php-master/languages/messages/MessagesEn.php seems to be the correct Messages file and contains the correct string, but that string does not show up in the login attempt on beta.  See screen shot.
Comment 1 Željko Filipin 2013-04-18 12:29:11 UTC
Test results:

en.wikipedia.beta.wmflabs.org, 3/6 tests failed

https://wmf.ci.cloudbees.com/job/_debug-browsertests-template/110/testReport/(root)/Log%20in/



test2.wikipedia.org, no failures

https://wmf.ci.cloudbees.com/job/_debug-browsertests-template/111/testReport/(root)/Log%20in/



en.wikipedia.org, 3/6 tests failed

https://wmf.ci.cloudbees.com/job/_debug-browsertests-template/112/testReport/(root)/Log%20in/



Both en.wikipedia.beta.wmflabs.org and en.wikipedia.org have 3 failed tests, but 2 test failures are the same, 1 is different.
Comment 2 Željko Filipin 2013-04-18 12:34:13 UTC
Both en.wikipedia.beta.wmflabs.org and en.wikipedia.org have "user name", only test2.wikipedia.org has "username". It would probably be better to change test2.wikipedia.org to behave like other sites.
Comment 3 Željko Filipin 2013-04-18 12:57:04 UTC
The test is checking the feedback error message after trying to log in with incorrect username. Is there a reason for different feedback messages when user provides incorrect username? (See attached login.png.)
Comment 4 Željko Filipin 2013-04-18 13:00:39 UTC
Created attachment 12135 [details]
Difference in feedback messages
Comment 5 Željko Filipin 2013-04-18 13:11:48 UTC
Similar problem happens when user tries to log in without entering any credentials: en.wikipedia.beta.wmflabs.org and en.wikipedia.org have "user name",
test2.wikipedia.org has "username". See attached screen shot.
Comment 6 Željko Filipin 2013-04-18 13:12:22 UTC
Created attachment 12137 [details]
username or user name
Comment 7 Sam Reed (reedy) 2013-04-18 13:15:06 UTC
http://en.wikipedia.beta.wmflabs.org/w/index.php?title=MediaWiki:Nosuchusershort&action=history

^ Local customi[zs]ations. Which makes this bug... invalid?
Comment 8 Željko Filipin 2013-04-18 13:16:37 UTC
And similar problem when user tries to log in without entering password, en.wikipedia.org has different feedback message than other sites. See attached screen shot.
Comment 9 Željko Filipin 2013-04-18 13:17:18 UTC
Created attachment 12138 [details]
password

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links