Last modified: 2013-04-18 15:24:20 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T49349, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 47349 - VisualEditor: Caption tags are stripped from tables when VE converts data model to DOM
VisualEditor: Caption tags are stripped from tables when VE converts data mod...
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
Data Model (Other open bugs)
unspecified
All All
: Normal major
: VE-deploy-2013-04-29
Assigned To: Ed Sanders
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-04-18 03:34 UTC by ssastry
Modified: 2013-04-18 15:24 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description ssastry 2013-04-18 03:34:10 UTC
1. Go to: http://ve-change-marking.instance-proxy.wmflabs.org/wiki/Test2
2. Open page in VisualEditor
3. Open browser console.
4. Run ve.dm.converter.getDomFromData( ve.instances[0].documentModel.store, ve.instances[0].documentModel.data.data ).body.outerHTML
5. You get the following output:
--------------
<body><table data-parsoid="{&quot;tsr&quot;:[0,3],&quot;dsr&quot;:[0,49,3,2]}">
This is a caption
<tbody data-parsoid="{&quot;dsr&quot;:[24,47,0,0]}"><tr data-parsoid="{&quot;tsr&quot;:[24,26],&quot;startTagSrc&quot;:&quot;|-&quot;,&quot;autoInsertedEnd&quot;:true,&quot;dsr&quot;:[24,46,2,0]}">
<td data-parsoid="{&quot;tsr&quot;:[27,28],&quot;autoInsertedEnd&quot;:true,&quot;dsr&quot;:[27,46,1,0]}">Table cell content</td></tr>
</tbody></table></body>
----------------

Notice the missing <caption> .. </caption> tags.
So, when Parsoid gets this, the caption is fostered out and shows up as a diff.
Comment 1 Roan Kattouw 2013-04-18 15:19:21 UTC
https://gerrit.wikimedia.org/r/59780
Comment 2 Roan Kattouw 2013-04-18 15:20:05 UTC
...which has already been merged.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links