Last modified: 2014-10-17 11:46:29 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T49361, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 47361 - Courses become "Passed" as the beginning of their last day instead of the end
Courses become "Passed" as the beginning of their last day instead of the end
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
EducationProgram (Other open bugs)
master
All All
: Normal minor (vote)
: ---
Assigned To: Nobody - You can work on this!
: easy
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2013-04-18 13:26 UTC by Sage Ross
Modified: 2014-10-17 11:46 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Sage Ross 2013-04-18 13:26:15 UTC 
Currently, a course becomes classified as Passed rather than Current at the beginning (UTC) of its end date. It should remain Current until the beginning of the following day instead.
Comment 1 Jeroen De Dauw 2013-04-23 19:49:19 UTC 
Change itself seems trivial. No tests for this yet though. Relevant code is also in the Course class, which currently has serious design issues, which need to be fixed for the CH changeover. Makes more sense to first add tests, fix the class design, then make this change.
Comment 2 Gerrit Notification Bot 2014-05-19 16:50:40 UTC 
Change 134116 had a related patch set uploaded by Ragesoss:
Fix when course status goes from current to passed

https://gerrit.wikimedia.org/r/134116
Comment 3 Gerrit Notification Bot 2014-05-22 16:07:09 UTC 
Change 134116 merged by jenkins-bot:
Fix when course status goes from current to passed

https://gerrit.wikimedia.org/r/134116
Comment 4 Andre Klapper 2014-10-17 11:46:29 UTC 
Patch was merged - assuming this bug is FIXED. If that is not the case: Please reopen and elaborate what is left to do here to get this report fixed.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links