Last modified: 2014-02-08 19:32:58 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T49393, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 47393 - git-deploy should allow separate restarts
git-deploy should allow separate restarts
Status: RESOLVED FIXED
Product: Wikimedia
Classification: Unclassified
Deployment systems (Other open bugs)
wmf-deployment
All All
: Normal normal (vote)
: ---
Assigned To: Ryan Lane
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-04-19 00:54 UTC by Roan Kattouw
Modified: 2014-02-08 19:32 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Roan Kattouw 2013-04-19 00:54:30 UTC
Currently, git-deploy automatically restarts the service after every deployment. For Parsoid, this is kind of evil, for two reasons.

First, we have two repositories, one for the code and one for the config. If we make dependent changes to these, deploying one of them will break the service, and deploying the second one will fix it again. When doing a deployment like this, we'd want to deploy both, then restart the service.

Second, even when only deploying one repo, it's generally desirable to test the change on one backend first. So it would be nice if we could deploy the change, restart one backend, sanity-test it, and then restart the rest of the cluster if it's fine. With the way things work currently, deploying broken code will instantly break the entire cluster.

So I'd like git-deploy to have a restart operation that restarts a service, either on the entire cluster or on one specific minion (this is needed to restart one backend for testing, because deployers don't necessarily have root), and for the restart-on-deploy behavior to be disableable.
Comment 1 Ryan Lane 2014-02-08 19:32:58 UTC
There's now a service-restart command that can be run for this. The command batch runs a restart across the minions, so that not every service restarts at the same time. It also gives reporting back on whether or not the restart was successful.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links