Last modified: 2013-04-23 16:50:11 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T49394, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 47394 - VisualEditor: MWTemplateNode should serialize original HTML if unchanged
VisualEditor: MWTemplateNode should serialize original HTML if unchanged
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
Data Model (Other open bugs)
unspecified
All All
: Normal normal
: VE-deploy-2013-04-29
Assigned To: Ed Sanders
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-04-19 03:15 UTC by Roan Kattouw
Modified: 2013-04-23 16:50 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Roan Kattouw 2013-04-19 03:15:16 UTC
If we get an MWTemplateNode and the user doesn't change it, then in the data->DOM conversion we should serialize it back out the way it came in, including all the other nodes (the template contents) that we normally discard.

Discarding these nodes when the user did change the template (i.e. the attributes changed) is fine and encouraged, but if we also do it when nothing changed, Parsoid's DOM diff algorithm will notice that we changed something in the DOM, causing selective serialization not to skip the template while it should.
Comment 1 Gerrit Notification Bot 2013-04-20 16:10:30 UTC
Related URL: https://gerrit.wikimedia.org/r/60110 (Gerrit Change I2bbb5d2d6a90c4eb87fa129671112c92a9b931e7)

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links