Last modified: 2013-12-10 04:09:35 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T49408, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 47408 - Inline comments wind up on wrong line in lines shown by +10⇧, +10⇩, etc
Inline comments wind up on wrong line in lines shown by +10⇧, +10⇩, etc
Status: NEW
Product: Wikimedia
Classification: Unclassified
Git/Gerrit (Other open bugs)
wmf-deployment
All All
: Unprioritized normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2013-04-19 13:09 UTC by Brad Jorsch
Modified: 2013-12-10 04:09 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Brad Jorsch 2013-04-19 13:09:50 UTC 
I've been seeing this bug for a while, where entering a comment on line N would sometimes store it for line N-1 instead. I've just now figured out how to reliably reproduce it.

1. Use the  +10⇧, +10⇩, or "skipped X common lines" links to show additional lines.
2. On one of those newly-shown lines, enter an inline comment. Note the line number.
3. Reload. See that the comment is one line above where it should be.

Watching the AJAX requests in Firebug, I see that submissions for lines shown at page load are sending the correct line number in the lineNbr field, while submissions for lines shown as above are sending the wrong number.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links