Last modified: 2013-07-05 22:05:22 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T49420, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 47420 - VisualEditor: Reopening page in VE immediately after saving page in VE loads old version


Summary:	VisualEditor: Reopening page in VE immediately after saving page in VE loads ...

Status:	RESOLVED FIXED

Product:	VisualEditor
Classification:	Unclassified
Component:	MediaWiki integration (Other open bugs)
Version:	unspecified
Hardware:	All All

Importance:	High normal
Target Milestone:	VE-deploy-2013-05-13
Assigned To:	Ed Sanders

URL:
Whiteboard:
Keywords:

Duplicates:	47682 48021 (view as bug list)
Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2013-04-19 17:51 UTC by ssastry
Modified:	2013-07-05 22:05 UTC (History)
CC List:	6 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description ssastry 2013-04-19 17:51:22 UTC

(a) open a page in VE and edit it
(b) save in VE 
(c) reopen the same page right away in VE

The previous version (rather than saved version) is fetched.  I looked at POST params in chrome and looks like revision id (oldid) being sent is of the older version rather than the saved version.

Comment 1 James Forrester 2013-04-19 18:22:50 UTC

Feels like we need to properly review how the integration around oldids works, given the number of issues. :-(

Comment 2 Roan Kattouw 2013-04-26 17:54:25 UTC

This is because we don't update this.oldid after saving.

Comment 3 Ed Sanders 2013-05-03 10:58:22 UTC

The JSON we get back after a save only contains the plain html and some timestamps. In order for us to update this.oldid we'll need Parsoid to tell us what it is, I think.

Comment 4 James Forrester 2013-05-03 15:30:38 UTC

(In reply to comment #3)
> The JSON we get back after a save only contains the plain html and some
> timestamps. In order for us to update this.oldid we'll need Parsoid to tell
> us what it is, I think.

Parsoid doesn't know; it's VisualEditor.php which does the actual saving to the DB.

Comment 5 Gerrit Notification Bot 2013-05-03 17:11:05 UTC

Related URL: https://gerrit.wikimedia.org/r/62168 (Gerrit Change I12ce27c8dc57f7aa753bcf5840635d5fea6b4e80)

Comment 6 James Forrester 2013-05-03 17:40:14 UTC

Now merged and will go into wmf4.

Comment 7 Raimond Spekking 2013-05-03 21:00:40 UTC

*** Bug 47682 has been marked as a duplicate of this bug. ***

Comment 8 Raimond Spekking 2013-05-03 21:00:53 UTC

*** Bug 48021 has been marked as a duplicate of this bug. ***

Comment 9 Axel Boldt 2013-07-05 09:18:07 UTC

This bug was closed as fixed on May 3 but I am still seeing this behavior on mediawiki.org. The second edit after saving loads the previous version of the page, not the current version. A warning "You are editing an out-of-date revision of this page" appears, but that doesn't help.

Comment 10 James Forrester 2013-07-05 22:00:39 UTC

Re-closing; new breakage is being tracked as bug 47420.

Comment 11 ssastry 2013-07-05 22:02:38 UTC

That is bug 50441.

Comment 12 James Forrester 2013-07-05 22:05:22 UTC

(In reply to comment #11)
> That is bug 50441.

Yes; sorry! :-)

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links