Last modified: 2013-07-04 10:33:16 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T49426, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 47426 - id in data-mw on templates triggers diff
id in data-mw on templates triggers diff
Status: RESOLVED FIXED
Product: Parsoid
Classification: Unclassified
General (Other open bugs)
unspecified
All All
: High normal
: ---
Assigned To: Gabriel Wicke
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2013-04-19 19:49 UTC by Gabriel Wicke
Modified: 2013-07-04 10:33 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Gabriel Wicke 2013-04-19 19:49:20 UTC 
The id reference in the data-mw attribute on template content (see http://www.mediawiki.org/wiki/Parsoid/MediaWiki_DOM_spec#Template_content) is not deterministic across re-parses. This makes it very likely that this attribute will serialize to a different string, which in turn causes the template node to be marked as 'modified-wrapper' in DOMDiff. The WTS serialization of the template often introduces some whitespace diffs around named parameters. Without a diff in data-mw selser would hide this issue.

The best solution for now is probably to leave out the id member from data-mw. There are no users for it currently, so this should not create issues.
Comment 1 Gerrit Notification Bot 2013-04-19 19:57:40 UTC 
Related URL: https://gerrit.wikimedia.org/r/60039 (Gerrit Change Ic615b11b5bc7cd7cb83a59ffa9fcccb135909a28)
Comment 2 Gerrit Notification Bot 2013-04-19 20:23:20 UTC 
https://gerrit.wikimedia.org/r/60039 (Gerrit Change Ic615b11b5bc7cd7cb83a59ffa9fcccb135909a28) | change APPROVED and MERGED [by jenkins-bot]
Comment 3 Andre Klapper 2013-07-04 10:33:16 UTC 
[Parsoid component reorg by merging JS/General and General. See bug 50685 for more information. Filter bugmail on this comment. parsoidreorg20130704]
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links