Last modified: 2013-05-22 23:34:49 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T49434, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 47434 - VisualEditor: No oldid is sent on POST to Parsoid
VisualEditor: No oldid is sent on POST to Parsoid
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
MediaWiki integration (Other open bugs)
unspecified
All All
: Highest normal
: VE-deploy-2013-04-29
Assigned To: Gabriel Wicke
:
: 47498 (view as bug list)
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2013-04-19 22:03 UTC by Gabriel Wicke
Modified: 2013-05-22 23:34 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Gabriel Wicke 2013-04-19 22:03:28 UTC 
As the title says. The bug seems to be in postHTML:

array(
        'postData' => array( 'content' => $html ),
        'timeout' => $wgVisualEditorParsoidTimeout,
        'oldid' => $parserParams['oldid']
)


should be:

array(
        'postData' => array( 'content' => $html, 
                             'oldid' =>  $parserParams['oldid']),
        'timeout' => $wgVisualEditorParsoidTimeout
)
Comment 1 James Forrester 2013-04-19 22:06:54 UTC 
This would explain a great deal. :-)
Comment 2 Gabriel Wicke 2013-04-19 22:07:17 UTC 
Verified that this fixes the problem and lets Parsoid actually use selective serialization. Current production code does not use selective serialization for this reason.
Comment 3 Gerrit Notification Bot 2013-04-19 22:14:50 UTC 
Related URL: https://gerrit.wikimedia.org/r/60082 (Gerrit Change Ib1b7079a7fd3357903e5a14795ed0d2f2bdc5d16)
Comment 4 James Forrester 2013-04-22 14:44:52 UTC 
Merged; to go out in next push as a critical priority.
Comment 5 Gabriel Wicke 2013-04-22 14:45:16 UTC 
*** Bug 47498 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links