Last modified: 2013-07-04 10:34:52 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T49513, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 47513 - Parsoid: Numbered Cite blocks are not generated starting from 1 but from a (random?) other number
Parsoid: Numbered Cite blocks are not generated starting from 1 but from a (r...
Status: RESOLVED FIXED
Product: Parsoid
Classification: Unclassified
General (Other open bugs)
unspecified
All All
: Low minor
: ---
Assigned To: ssastry
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-04-22 19:31 UTC by James Forrester
Modified: 2013-07-04 10:34 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description James Forrester 2013-04-22 19:31:46 UTC
See for example http://parsoid.wmflabs.org/en/Foobar - output is [457] rather than [1] for the first one.
Comment 1 Gabriel Wicke 2013-04-22 20:07:53 UTC
Lowering priority as this is purely cosmetic and does not affect round-tripping or editing.
Comment 2 James Forrester 2013-04-22 20:08:41 UTC
But affects user confidence in Parsoid catastrophically. :-)
Comment 3 ssastry 2013-04-23 09:57:26 UTC
Patch submitted @ https://gerrit.wikimedia.org/r/#/c/60378/2
Comment 4 Gerrit Notification Bot 2013-04-24 07:02:47 UTC
Related URL: https://gerrit.wikimedia.org/r/60631 (Gerrit Change I490edd52be75d8484358a07bef783080f4604f86)
Comment 5 ssastry 2013-04-24 07:09:43 UTC
The two patches are independent of each other.  But, 60631 is the real fix for this bug.

- 60378 will fix the bug when a page always has a references tag. It is required to reset ref indexes when a page has multiple reference tags. As a result, it will ensure that state is reset when the last references tag on the page is a global references tag.  But, will not work in other scenarios.

- 60631 will fix the bug by ensuring global parser state is reset before each page is parsed.  This doesn't however ensure that ref indexes are reset after each references tag when a page has multiple reference tags.
Comment 6 ssastry 2013-04-25 01:56:39 UTC
Now merged.  To be verified in production once Parsoid is redeployed.
Comment 7 James Forrester 2013-04-25 16:30:42 UTC
Confirmed working in production - thanks! Marking as fixed.
Comment 8 Andre Klapper 2013-07-04 10:34:52 UTC
[Parsoid component reorg by merging JS/General and General. See bug 50685 for more information. Filter bugmail on this comment. parsoidreorg20130704]

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links