Last modified: 2013-04-25 23:17:20 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T49532, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 47532 - Agora CSS gives labels conflicting styles
Agora CSS gives labels conflicting styles
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Interface (Other open bugs)
1.22.0
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-04-23 07:23 UTC by spage
Modified: 2013-04-25 23:17 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description spage 2013-04-23 07:23:49 UTC
resources/mediawiki.ui/sourcefiles/scss/components/default/_forms.scss gives conflicting CSS for labels.  Line 25 specifies
  margin: 0;
  width: 100%
but then line 39 in the same & > div block specifies
  width: auto;
  margin: 0 0 0.2em 0;

The later CSS wins according to Firebug.

Perhaps we can just remove label from the first Sass selector. But then the label isn't styled display: block , and AIUI as a result in Firefox it's squeezed tighter to the input field underneath.  I think you get identical effective CSS by adding
     display: block;
     @include box-sizing(border-box);

to the label declaration, but maybe that's overthinking it.
Comment 1 Gerrit Notification Bot 2013-04-23 07:27:17 UTC
Related URL: https://gerrit.wikimedia.org/r/60373 (Gerrit Change Ibd36f818865aa5ec99cc187bef983261485966d3)
Comment 2 Gerrit Notification Bot 2013-04-24 20:49:47 UTC
Related URL: https://gerrit.wikimedia.org/r/60740 (Gerrit Change Ibd36f818865aa5ec99cc187bef983261485966d3)
Comment 3 spage 2013-04-25 23:17:20 UTC
We went with the fix.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links