Last modified: 2013-05-03 02:52:32 UTC
For previous split tests, we incorrectly logged views of the control landing page (the MediaWiki default welcome creation) as gettingstarted-impression, giving the false, uh... impression that control users had been served the test condition.
GettingStarted.hooks.php sets a flag $isWelcomeCreation if the user has just created an account, regardless of what page the user is shown. ext.gettingstarted.openTask.js uses it for isNew (good), but also uses it to determine isGettingStarted(). This predates the JS code that switches the browser history state from create account form to Special:GettingStarted. So I think isGettingStarted() doesn't need to check cfg.wgIsWelcomeCreation any more. (If necessary it could check for something defined in ext.gettingstarted.accountcreation.js, which is only sent to the browser if it's the Special:GS page.)
To MediaWiki the page the user is seeing is still Userlogin, so you do have to check for something. Easiest (but fragile) to look for the ext.gettingstarted.accountcreation module, patch forthcoming.
Related URL: https://gerrit.wikimedia.org/r/60787 (Gerrit Change Iaff9f7226aa77b0e8b8abb8c32b549f64cc42d8a)
As part of the https://gerrit.wikimedia.org/r/#/c/59575/ restructuring, I removed the isGettingStarted function entirely.
