Last modified: 2013-05-20 19:21:31 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T49699, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 47699 - Excess white space between the bottom of the captcha image and refresh link
Excess white space between the bottom of the captcha image and refresh link
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
User login and signup (Other open bugs)
1.22.0
All All
: Low minor (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-04-26 00:25 UTC by Thehelpfulone
Modified: 2013-05-20 19:21 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---
greg: Backport_WMF+


Attachments
Screenshot showing excess white space between captcha and refresh link (102.09 KB, image/png)
2013-04-26 00:38 UTC, Thehelpfulone
Details

Comment 1 MZMcBride 2013-04-26 00:30:37 UTC
The CAPTCHA only displays at that link while logged out. A comparison screenshot here would be helpful.
Comment 2 Thehelpfulone 2013-04-26 00:38:43 UTC
Created attachment 12186 [details]
Screenshot showing excess white space between captcha and refresh link

Per request - I've selected the captcha so that you can see where it ends and gap between it and the refresh link.
Comment 3 Matthew Flaschen 2013-04-26 01:00:57 UTC
The CAPTCHAs vary in height.  I put a min-height of 95 (which seems to be a close upper bound) to accomplish two goals:

1. Don't scale or skew the CAPTCHA.  We don't want to make it even less readable.
2. Don't have the move jump vertically when they ask for a new CAPTCHA.

If this seems to be worse than jumping, we could look at removing the min-height.  Or, we could change the CAPTCHA generation script to output fixed height images (a bigger project).
Comment 4 Steven Walling 2013-04-26 23:54:43 UTC
I think https://gerrit.wikimedia.org/r/#/c/61155/ will address this?
Comment 5 Matthew Flaschen 2013-04-27 00:04:57 UTC
No, that's just to avoid splitting the reload text and reload image.  This is about the whitespace in the CAPTCHA
Comment 6 spage 2013-05-03 18:49:25 UTC
See also bug 47713
Comment 7 Gerrit Notification Bot 2013-05-03 20:27:16 UTC
Related URL: https://gerrit.wikimedia.org/r/62191 (Gerrit Change I57be0bc8aa80b9ea6148db979ad28397d2107b86)
Comment 8 Gerrit Notification Bot 2013-05-06 23:37:47 UTC
Related URL: https://gerrit.wikimedia.org/r/62542 (Gerrit Change I003c5f1b75471cce32b149037198c314ce9489ea)
Comment 9 Gerrit Notification Bot 2013-05-16 21:21:54 UTC
Related URL: https://gerrit.wikimedia.org/r/64203 (Gerrit Change I003c5f1b75471cce32b149037198c314ce9489ea)
Comment 10 Gerrit Notification Bot 2013-05-17 01:30:36 UTC
Related URL: https://gerrit.wikimedia.org/r/64250 (Gerrit Change I003c5f1b75471cce32b149037198c314ce9489ea)
Comment 11 spage 2013-05-17 02:01:02 UTC
E3 requesting backport to wmf4 (only) with Gerrit change #64250 so this change to the new Create account form can accompany the wmf4 roll-out. Low-risk since the new forms are opt-in.
Comment 12 spage 2013-05-17 19:15:52 UTC
Backport like bug 47801
Comment 13 spage 2013-05-20 19:21:31 UTC
Fix is backported to wmf4. The captcha is a little closer because it's inside the fancycaptcha-image-container, whose min-height we set to 95 so the rest of the form doesn't (well, rarely) shift up and down each time you refresh the captcha image.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links